Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to copy current file name #22174

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ankddev
Copy link

@ankddev ankddev commented Dec 18, 2024

Closes #21967

Description

This PR adds commands to copy current file's name.

Screenshots

Project View

image

Editor command (command palette)

image

Tab's menu

image

Release Notes:

  • Added commands to copy current file name

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 18, 2024
@ankddev ankddev changed the title feat: copy current file name feat: copy current file name command Dec 18, 2024
@ankddev ankddev force-pushed the copy-current-filename branch 2 times, most recently from 10f00ed to 7148e07 Compare December 18, 2024 12:41
@maxdeviant maxdeviant changed the title feat: copy current file name command Add command to copy current file name command Dec 18, 2024
@maxdeviant maxdeviant changed the title Add command to copy current file name command Add command to copy current file name Dec 18, 2024
@notpeter
Copy link
Member

  1. I don't think this is not a common enough operation that it deserves placement in default the project_panel or tab right click menu.

  2. Probably the action names should reversed so it's CopyFileName and CopyFileNameWithoutExtension. As I would assume the CopyFileName action would give me the filename, not a truncated version of it.

@ankddev
Copy link
Author

ankddev commented Dec 18, 2024

Okay, I will do it tommorow.

@notpeter notpeter self-assigned this Dec 18, 2024
@ankddev ankddev force-pushed the copy-current-filename branch from 7148e07 to 374ec51 Compare December 19, 2024 03:26
@ankddev
Copy link
Author

ankddev commented Dec 19, 2024

@notpeter I renamed commands and removed them fom tab's menu. Should I also remove these commands from project_panel's menu?

@ankddev ankddev force-pushed the copy-current-filename branch from fca0609 to e233e1d Compare December 19, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy current filename command
2 participants