Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multibuffer excerpt affordances #22167

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
+468 −316
Open

Improve multibuffer excerpt affordances #22167

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a252259
Add new tooltip type `with_meta_in`
danilo-leal Dec 17, 2024
6f434ed
Adjust the "Jump to Location" tooltip
danilo-leal Dec 17, 2024
941f1e6
Checkpoint: Mostly working, with bugs
danilo-leal Dec 17, 2024
40b8942
Start the work for the whole block dividing excerpts to be an expand …
danilo-leal Dec 18, 2024
4cfc789
Fix click event on expand area spilling out to the editor
danilo-leal Dec 18, 2024
edc06f5
Fix expand area tooltip flicker
danilo-leal Dec 18, 2024
c22fdfc
Make icon color change on hover
danilo-leal Dec 18, 2024
2896065
Show the "Jump to File" keybinding just on the header
danilo-leal Dec 18, 2024
ef1eb7b
Add divider lines to diagnostic excerpts, too
danilo-leal Dec 19, 2024
e75bc4f
Clean up: Remove comments and resolve warnings
danilo-leal Dec 19, 2024
8444654
Merge branch 'main' into multibuffer-excerpt-interaction-improvement
danilo-leal Dec 20, 2024
7a883a3
Checkpoint
SomeoneToIgnore Dec 23, 2024
329489d
Draft navigating into buffers using rows
SomeoneToIgnore Dec 23, 2024
41747ca
Fix navigation bugs
SomeoneToIgnore Dec 23, 2024
d7092e1
Rework line numbers' access during click handling
SomeoneToIgnore Dec 23, 2024
6cd1bdf
Underline hovered line in buffers
SomeoneToIgnore Dec 23, 2024
f5cc136
Fixes
SomeoneToIgnore Dec 23, 2024
1a331ff
Fix the tests
SomeoneToIgnore Dec 23, 2024
62bded6
Adjust line number hover styles
danilo-leal Dec 23, 2024
c92c00e
Merge branch 'main' into multibuffer-excerpt-interaction-improvement
danilo-leal Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add new tooltip type with_meta_in
  • Loading branch information
@danilo-leal
danilo-leal committed Dec 17, 2024
commit a2522598be8198de434241dab7728e5f26c17bb6
17 changes: 17 additions & 0 deletions crates/ui/src/components/tooltip.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ impl Tooltip {
})
.into()
}

pub fn with_meta(
title: impl Into<SharedString>,
action: Option<&dyn Action>,
Expand All @@ -63,6 +64,22 @@ impl Tooltip {
.into()
}

pub fn with_meta_in(
title: impl Into<SharedString>,
action: Option<&dyn Action>,
meta: impl Into<SharedString>,
focus_handle: &FocusHandle,
cx: &mut WindowContext,
) -> AnyView {
cx.new_view(|cx| Self {
title: title.into(),
meta: Some(meta.into()),
key_binding: action
.and_then(|action| KeyBinding::for_action_in(action, focus_handle, cx)),
})
.into()
}

pub fn new(title: impl Into<SharedString>) -> Self {
Self {
title: title.into(),
Expand Down