Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multibuffer excerpt affordances #22167

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Improve multibuffer excerpt affordances #22167

wants to merge 20 commits into from
+468 −316

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Dec 17, 2024 •
edited
Loading

Work in progress:

Features:

  • Increase expand affordance surface area
  • Ensure expand buttons have tooltips with keybindings
  • Make line numbers clickable (jump you to location)
  • Ensure line numbers display tooltips with keybindings (only on multibuffers)
  • Consider making line numbers clickable only in multibuffers
  • Experiment with increasing the width of the clickable surface area for line numbers
  • Hide the "Jump To File" element in not-focused excerpts

Bugs:

  • Cursor issue when clicking on lines

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 17, 2024
danilo-leal and others added 15 commits December 18, 2024 01:14
@danilo-leal
Start the work for the whole block dividing excerpts to be an expand …
40b8942 
…button
@danilo-leal @mrnugget
Fix click event on expand area spilling out to the editor
4cfc789 
Co-Authored-By: Thorsten Ball <mrnugget@gmail.com>
@danilo-leal @mrnugget
Fix expand area tooltip flicker
edc06f5 
Co-Authored-By: Thorsten Ball <mrnugget@gmail.com>
@danilo-leal
Make icon color change on hover
c22fdfc
@danilo-leal @agu-z
Show the "Jump to File" keybinding just on the header
2896065 
Co-Authored-By: Agus Zubiaga <hi@aguz.me>
@danilo-leal
Add divider lines to diagnostic excerpts, too
ef1eb7b
@danilo-leal
Clean up: Remove comments and resolve warnings
e75bc4f
@danilo-leal
Merge branch 'main' into multibuffer-excerpt-interaction-improvement
8444654
@SomeoneToIgnore
Checkpoint
7a883a3
@SomeoneToIgnore @agu-z
Draft navigating into buffers using rows
329489d 
co-authored-by: Agus Zubiaga <agus@zed.dev>
@SomeoneToIgnore @agu-z
Fix navigation bugs
41747ca 
co-authored-by: Agus Zubiaga <agus@zed.dev>
@SomeoneToIgnore
Rework line numbers' access during click handling
d7092e1
@SomeoneToIgnore
Underline hovered line in buffers
6cd1bdf
@SomeoneToIgnore
Fixes
f5cc136
@SomeoneToIgnore
Fix the tests
1a331ff
@SomeoneToIgnore SomeoneToIgnore force-pushed the multibuffer-excerpt-interaction-improvement branch from 7e89b67 to 1a331ff Compare December 23, 2024 22:12
@danilo-leal danilo-leal marked this pull request as ready for review December 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilo-leal @SomeoneToIgnore