Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image information #21281

Open
1 task done
Angelk90 opened this issue Nov 28, 2024 · 5 comments · May be fixed by #21675
Open
1 task done

Image information #21281

Angelk90 opened this issue Nov 28, 2024 · 5 comments · May be fixed by #21675
Labels
enhancement [core label] good first issue Issue suitable for first-time contributors image viewer Feedback for image preview, zoom, manipulation, etc

Comments

@Angelk90
Copy link
Contributor

Check for existing issues

  • Completed

Describe the feature

It would be nice for the images to know its size height X length and its size.

Screenshot 2024-11-28 alle 15 13 37

Environment

Zed: v0.161.0 (Zed Preview)
OS: macOS 14.1.1
Memory: 16 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@Angelk90 Angelk90 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Nov 28, 2024
@jansol jansol added good first issue Issue suitable for first-time contributors image viewer Feedback for image preview, zoom, manipulation, etc and removed triage Maintainer needs to classify the issue labels Nov 29, 2024
@notpeter notpeter removed the admin read Pending admin review label Dec 2, 2024
@github-actions github-actions bot mentioned this issue Dec 3, 2024
Open
@kaf-lamed-beyt
Copy link

@jansol, i can see that this issue has a "good first issue" label. Can you point me in the right direction? Which file/folders am I to look at?

@jansol
Copy link
Contributor

jansol commented Dec 6, 2024

Looking at the past pull requests to the image viewer crates/image_viewer/src/image_viewer.rs

@kaf-lamed-beyt
Copy link

kaf-lamed-beyt commented Dec 6, 2024 •
edited
Loading

alright! thank you. I'll take a look now

[EDIT]: I've been able to make sense of the file, and what I need to do. Can I be assigned? cc: @jansol

@jansol
Copy link
Contributor

jansol commented Dec 6, 2024

Feel free to hack on it if you want! Community contributors aren't usually formally assigned to issues. Just announcing that you are working on something is enough. (And even that isn't really required.)

@kaf-lamed-beyt
Copy link

Awesome! When i send a PR. I'll let you know. Thanks @jansol

@kaf-lamed-beyt kaf-lamed-beyt linked a pull request Dec 7, 2024 that will close this issue
Draft
@notpeter notpeter mentioned this issue Dec 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement [core label] good first issue Issue suitable for first-time contributors image viewer Feedback for image preview, zoom, manipulation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add image dimension and file size information kaf-lamed-beyt/zed
4 participants
@notpeter @jansol @Angelk90 @kaf-lamed-beyt