Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check during image discovery to make sure images are valid #3234

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

a1994sc
Copy link
Contributor

@a1994sc a1994sc commented Nov 12, 2024

Description

When using zarf to discover images with the Ironbank chart kyverno-policies, the restrict-image-registries policy, (simple version included in tests), has an entry of:

  • registry.dso.mil/*

This is a false positive and cases cosign looks up to fail as that is not a valid image.

Checklist before merging

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit f811a85
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6733c4caa3301a0008950240

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 3995e10
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6745c03f433cde00086b789e

@a1994sc a1994sc marked this pull request as ready for review November 12, 2024 21:18
@a1994sc a1994sc requested review from a team as code owners November 12, 2024 21:18
@a1994sc
Copy link
Contributor Author

a1994sc commented Nov 20, 2024

Related to #3253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant