Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repository.go #2996

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix repository.go #2996

wants to merge 1 commit into from

Conversation

ittacco
Copy link

@ittacco ittacco commented Sep 14, 2024

fix: Clone of Azure devops git repo not working with private repositories

Refs: #2994

Description

Added return in case the Repository is correctly cloned by gitCloneFallback

Related Issue

Fixes #2994

Checklist before merging

@ittacco ittacco requested review from a team as code owners September 14, 2024 12:49
@netlify Netlify
Copy link

netlify bot commented Sep 14, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 3770dce
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6746088d662d940008b1b12f

phillebaba
phillebaba requested changes Sep 14, 2024
View reviewed changes
Copy link
Member

@phillebaba phillebaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting, I wonder if this is a regression from the error work that has been done or if this has always been here?

Not sure if this is easily testable but could be worth it to avoid regression.

src/internal/git/repository.go Outdated Show resolved Hide resolved
@ittacco ittacco requested a review from phillebaba October 18, 2024 16:51
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/git/repository.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/internal/git/repository.go 16.91% <0.00%> (-0.09%) ⬇️

@schristoff
Copy link
Contributor

Hey! Could you please sign DCO so we can get this merged? :)

@schristoff schristoff added the needs-DCO needs DCO signed to merge label Nov 7, 2024
@ittacco
Copy link
Author

ittacco commented Nov 9, 2024

Hi @schristoff , I hope DCO are ok now!

@AustinAbro321
Copy link
Contributor

@ittacco Hey looks like something went wrong when you did DCO, it's currently showing 240 files changed. Could you reset this PR, I know it was originally a couple line change. If you git reset main then re add your changes, sign your commit and force push it should work.

@ittacco
fixed Clone function to return after gitCloneFallback
3770dce 
Signed-off-by: ittacco <lorenzo.tacconi1967@gmail.com>
@ittacco
Copy link
Author

ittacco commented Nov 26, 2024

Hi @AustinAbro321, I hope it's ok, just 1 commit with correct DCO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillebaba phillebaba Awaiting requested review from phillebaba

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs-DCO needs DCO signed to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clone of Azure devops git repo not working with private repositories
4 participants
@ittacco @schristoff @AustinAbro321 @phillebaba