Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] fix flake tests with image validation API errors #7989

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

[e2e] fix flake tests with image validation API errors #7989

wants to merge 7 commits into from

Conversation

demonCoder95
Copy link
Member

@demonCoder95 demonCoder95 commented Aug 26, 2024 •
edited
Loading

E2e tests often fail because the image validation API return 502 return status, which causes the image admission to fail and the test fails.

Reason:FailedCreate Message:admission webhook \"pod-admitter.teapot.zalan.do\" denied the request: image check for registry.opensource.zalan.do/teapot/skipper:v0.14.0 failed: unexpected HTTP response status: 502 Bad Gateway

Looking at docker-meta logs we see the base image has expired

INFO:meta.opa:'registry.opensource.zalan.do/teapot/skipper:v0.17.2' base image is not allowed (['base image registry.opensource.zalan.do/library/alpine-3:3-20230731 is expired.']). OPA Input:

This PR updates the compliant images so that the check doesn't fail.

@demonCoder95 demonCoder95 added bugfix Bug fixes and patches, e.g. fixing of a production issue that is affecting the customer experience. do-not-merge labels Aug 26, 2024
@demonCoder95
Copy link
Member Author

demonCoder95 commented Aug 27, 2024 •
edited
Loading

Adding the compliance namespace to the softfail list for the admission-controller doesn't seem to fix the issue for now, will investigate further.

Update: Decided to update image references, let's see if it resolves the issue.

@MustafaSaber
Copy link
Member

👍

@demonCoder95
Copy link
Member Author

Rebased on latest dev, will try working on this and resolving the issue so we can no longer rely on the softfail configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linki linki linki left review comments

Assignees
No one assigned
Labels
bugfix Bug fixes and patches, e.g. fixing of a production issue that is affecting the customer experience. do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@demonCoder95 @MustafaSaber @linki