Add test for empty array

zaggino · Apr 4, 2019 · a11b433 · a11b433
1 parent 0f444a2
commit a11b433
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/dist/ZSchema-browser.js b/dist/ZSchema-browser.js
@@ -7231,7 +7231,8 @@ var FormatValidators = require("./FormatValidators"),
 var shouldSkipValidate = function (options, errors) {
     return options &&
         Array.isArray(options.includeErrors) &&
-        (options.includeErrors.length === 0 || !errors.some(function (err) { return options.includeErrors.includes(err);}));
+        options.includeErrors.length > 0 &&
+        !errors.some(function (err) { return options.includeErrors.includes(err);});
 };
 
 var JsonValidators = {

diff --git a/src/JsonValidation.js b/src/JsonValidation.js
@@ -7,7 +7,8 @@ var FormatValidators = require("./FormatValidators"),
 var shouldSkipValidate = function (options, errors) {
     return options &&
         Array.isArray(options.includeErrors) &&
-        (options.includeErrors.length === 0 || !errors.some(function (err) { return options.includeErrors.includes(err);}));
+        options.includeErrors.length > 0 &&
+        !errors.some(function (err) { return options.includeErrors.includes(err);});
 };
 
 var JsonValidators = {

diff --git a/test/ZSchemaTestSuite/IncludeErrors.js b/test/ZSchemaTestSuite/IncludeErrors.js
@@ -79,11 +79,33 @@ module.exports = {
                 hello: "world",
                 extra: "extra"
             },
-            description: "should fail validation for all errors when empty array is provided.",
+            description: "should fail validation for all errors when no `includeErrors` array is provided.",
             valid: false,
             after: function(errs) {
                 expect(errs.length).toBe(2);
             }
         },
+        {
+            schema: {
+                "type": "object",
+                "properties": {
+                    "hello": {
+                        "type": "number"
+                    }
+                }
+            },
+            data: {
+                hello: "world",
+                extra: "extra"
+            },
+            validateOptions: { 
+                includeErrors: []
+            },
+            description: "should fail validation for all errors when empty array is provided.",
+            valid: false,
+            after: function(errs) {
+                expect(errs.length).toBe(2);
+            }
+        }
     ]
 };