Remove useless function in Edit Table dialog

yunzixun · Jan 23, 2017 · f728ff7 · f728ff7
1 parent b6b94a8
commit f728ff7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/src/EditTableDialog.cpp b/src/EditTableDialog.cpp
@@ -257,7 +257,7 @@ void EditTableDialog::itemChanged(QTreeWidgetItem *item, int column)
         {
         case kName:
             // When a field of that name already exists, show a warning to the user and don't apply the new name
-            if(fieldNameExists(item->text(column)))
+            if(m_table.findField(item->text(column)))
             {
                 QMessageBox::warning(this, qApp->applicationName(), tr("There already is a field with that name. Please rename it first or choose a different "
                                                                        "name for this field."));
@@ -504,7 +504,7 @@ void EditTableDialog::addField()
         {
             field_name = "Field" + QString::number(field_number);
             field_number++;
-        } while(fieldNameExists(field_name));
+        } while(m_table.findField(field_name));
         tbitem->setText(kName, field_name);
     }
 
@@ -729,14 +729,3 @@ void EditTableDialog::setTemporary(bool is_temp)
         }
     }
 }
-
-bool EditTableDialog::fieldNameExists(const QString& name)
-{
-    foreach(const sqlb::FieldPtr& ptr, m_table.fields())
-    {
-        if(ptr->name() == name)
-            return true;
-    }
-
-    return false;
-}
diff --git a/src/EditTableDialog.h b/src/EditTableDialog.h
@@ -42,9 +42,6 @@ class EditTableDialog : public QDialog
 
     void moveCurrentField(bool down);
 
-    // Returns true if there already is a field of that name
-    bool fieldNameExists(const QString& name);
-
 private slots:
     void populateFields();
     void addField();