Fix memory leak (Coverity)

yunzixun · Feb 11, 2017 · 81c0cf3 · 81c0cf3
1 parent 47cfd55
commit 81c0cf3
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/sqlitetypes.cpp b/src/sqlitetypes.cpp
@@ -955,9 +955,15 @@ void CreateTableWalker::parsecolumn(Table* table, antlr::RefAST c)
     {
         FieldVector v;
         if(table->constraint(v, Constraint::PrimaryKeyConstraintType))
+        {
             table->primaryKeyRef().push_back(f);
-        else
+
+            // Delete useless primary key constraint. There already is a primary key object for this table, we
+            // don't need another one.
+            delete primaryKey;
+        } else {
             table->addConstraint({f}, ConstraintPtr(primaryKey));
+        }
     }
 }