Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lack of parts of implement of the papar #87

Open
AlvinAi96 opened this issue Jun 10, 2019 · 0 comments
Open

A lack of parts of implement of the papar #87

AlvinAi96 opened this issue Jun 10, 2019 · 0 comments

Comments

@AlvinAi96
Copy link

AlvinAi96 commented Jun 10, 2019

Although the code looks nice, I found this code isn't intact. If someone is trying to use it, please be careful.

  1. maxlen: it shouldn't be the fixed-length as it defined as 15. In the paper, section 4.3 Training Proceduce, author uses the other method which is corresponding the homogeneous_data.py in the paper's code.
  2. Beam search: this code doesn't implement beam search.

So far, I only found out these things and I decide to use the paper's original code instead of this. Anyway, I still appreciate the tensorflow attempt. The code is clear and beautiful. Thanks for sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant