Update py_lint and py_test (kubeflow#569)

* Update py_lint and py_test kubeflow/testing#111 refactored these two tests into two separate files /cc @gaocegege * Ignore jupyterhub_spawner.py
yph152 · Jun 18, 2018 · fcc8073 · fcc8073
1 parent c863e66
commit fcc8073
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/.pylintrc b/.pylintrc
@@ -9,7 +9,7 @@
 
 # Add files or directories to the blacklist. They should be base names, not
 # paths.
-ignore=third_party
+ignore=third_party,jupyterhub_spawner.py
 
 # Add files or directories matching the regex patterns to the blacklist. The
 # regex matches against base names, not paths.
@@ -58,7 +58,7 @@ confidence=
 # --disable=W"
 #
 # Kubeflow disables wrong-import-order error because we were getting different results regarding third party
-# modules when running locally vs in our test infrastructure. It looks like what counts 
+# modules when running locally vs in our test infrastructure. It looks like what counts
 # as third party might vary.
 #
 disable=import-star-module-level,old-octal-literal,oct-method,print-statement,unpacking-in-except,parameter-unpacking,backtick,old-raise-syntax,old-ne-operator,long-suffix,dict-view-method,dict-iter-method,metaclass-assignment,next-method-called,raising-string,indexing-exception,raw_input-builtin,long-builtin,file-builtin,execfile-builtin,coerce-builtin,cmp-builtin,buffer-builtin,basestring-builtin,apply-builtin,filter-builtin-not-iterating,using-cmp-argument,useless-suppression,range-builtin-not-iterating,suppressed-message,missing-docstring,no-absolute-import,old-division,cmp-method,reload-builtin,zip-builtin-not-iterating,intern-builtin,unichr-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,input-builtin,round-builtin,hex-method,nonzero-method,map-builtin-not-iterating,relative-import,invalid-name,bad-continuation,no-member,locally-disabled,fixme,import-error,too-many-locals,wrong-import-order
@@ -401,4 +401,4 @@ exclude-protected=_asdict,_fields,_replace,_source,_make
 
 # Exceptions that will emit a warning when being caught. Defaults to
 # "Exception"
-overgeneral-exceptions=Exception
+overgeneral-exceptions=Exception
diff --git a/test/workflows/components/workflows.libsonnet b/test/workflows/components/workflows.libsonnet
@@ -260,20 +260,16 @@
             $.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("py-test", [
               "python",
               "-m",
-              "py.py_checks",
-              "test",
+              "kubeflow.testing.test_py_checks",
+              "--artifacts_dir=" + artifactsDir,
               "--src_dir=" + srcDir,
-              "--project=" + project,
-              "--junit_path=" + artifactsDir + "/junit_pycheckstest.xml",
             ]),  // py test
             $.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("py-lint", [
               "python",
               "-m",
-              "py.py_checks",
-              "lint",
+              "kubeflow.testing.test_py_lint",
+              "--artifacts_dir=" + artifactsDir,
               "--src_dir=" + srcDir,
-              "--project=" + project,
-              "--junit_path=" + artifactsDir + "/junit_pycheckslint.xml",
             ]),  // py lint
             $.parts(namespace, name).e2e(prow_env, bucket).buildTemplate("setup-cluster", [
               "python",