make errors more friendly

you-n-g · Jul 21, 2020 · 0eb6f36 · 0eb6f36
1 parent 32bb23d
commit 0eb6f36
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -7,7 +7,10 @@ This package is under development.  We will release it soon in the future.
 
 # Installation
 
-[fzf](https://github.com/junegunn/fzf) is required
+<!-- [fzf](https://github.com/junegunn/fzf) is required -->
+```shell
+pip install wan  # TODO: upload this to pip source
+```
 
 ## config
 

diff --git a/wan/__init__.py b/wan/__init__.py
@@ -80,7 +80,7 @@ def wait(self, pid=None, message=None, idle=False, patience=20, sleep=3):
         if pid is None:
             pid = get_pid_via_fzf()
             if pid is None:
-                logger.info('No process selected')
+                logger.info('No process selected, You can used --pid to specify the process')
                 return
 
         process_info = self._get_process_info(pid)

diff --git a/wan/utils.py b/wan/utils.py
@@ -1,5 +1,6 @@
 import subprocess
 from iterfzf import iterfzf
+from loguru import logger
 
 
 def iter_ps():
@@ -14,7 +15,12 @@ def get_pid_from_line(line):
 
 
 def get_pid_via_fzf(exact=True):
-    return get_pid_from_line(iterfzf(iter_ps(), multi=False, exact=exact))
+    try:
+        selected_line = iterfzf(iter_ps(), multi=False, exact=exact)
+    except PermissionError as e:
+        logger.error(f'Please make {e.filename} executable(e.g  `chmod a+x {e.filename}`).')
+        return None
+    return get_pid_from_line(selected_line)
 
 
 if __name__ == "__main__":