chore: drop python 3.8 support (sparckles#1079)

yomaaf · Dec 11, 2024 · 5bfc37a · 5bfc37a
1 parent 3da7c3b
commit 5bfc37a
Show file tree

Hide file tree

Showing 9 changed files with 124 additions and 96 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -42,7 +42,6 @@ body:
     attributes:
       label: Your Python version (`python --version`)
       options:
-        - 3.8
         - 3.9
         - 3.10
         - 3.11

diff --git a/.github/workflows/codspeed.yml b/.github/workflows/codspeed.yml
@@ -17,14 +17,13 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
-      
+
       - name: Install uv
         uses: astral-sh/setup-uv@v3
-      
+
       - uses: actions/setup-python@v5
         with:
-          python-version: "3.8"
-
+          python-version: "3.9"
 
       - name: Install dependencies with uv
         run: |
@@ -43,4 +42,5 @@ jobs:
         uses: CodSpeedHQ/action@v2
         with:
           token: ${{ secrets.CODSPEED_TOKEN }}
-          run: pytest integration_tests --codspeed
+          run: pytest integration_tests --codspeed
+
diff --git a/.github/workflows/preview-deployments.yml b/.github/workflows/preview-deployments.yml
@@ -19,7 +19,7 @@ jobs:
     runs-on: macos-12
     strategy:
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     steps:
       - uses: actions/checkout@v4
       - name: Install uv
@@ -52,7 +52,7 @@ jobs:
     runs-on: windows-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         target: [x64, x86]
     steps:
       - uses: actions/checkout@v4
@@ -78,7 +78,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         target: [x86_64, i686]
     steps:
       - uses: actions/checkout@v4
@@ -107,7 +107,6 @@ jobs:
       matrix:
         python:
           [
-            { version: "3.8", abi: "cp38-cp38" },
             { version: "3.9", abi: "cp39-cp39" },
             { version: "3.10", abi: "cp310-cp310" },
             { version: "3.11", abi: "cp311-cp311" },
@@ -149,4 +148,5 @@ jobs:
             source venv/bin/activate
             pip install --upgrade pip setuptools wheel
             pip install --force-reinstall dist/robyn*.whl
-            cd ~ && python -c 'import robyn'
+            cd ~ && python -c 'import robyn'
+
diff --git a/.github/workflows/python-CI.yml b/.github/workflows/python-CI.yml
@@ -10,7 +10,7 @@ jobs:
       fail-fast: false
       matrix:
         os: ["windows", "ubuntu", "macos"]
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     name: ${{ matrix.os }} tests with python ${{ matrix.python-version }}
     runs-on: ${{ matrix.os }}-latest
     steps:

diff --git a/.github/workflows/release-CI.yml b/.github/workflows/release-CI.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on: macos-12
     strategy:
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     steps:
       - uses: actions/checkout@v3
       - name: Install uv
@@ -48,7 +48,7 @@ jobs:
     runs-on: windows-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         target: [x64, x86]
     steps:
       - uses: actions/checkout@v3
@@ -78,7 +78,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         target: [x86_64, i686]
     steps:
       - uses: actions/checkout@v3
@@ -110,7 +110,6 @@ jobs:
       matrix:
         python:
           [
-            { version: "3.8", abi: "cp38-cp38" },
             { version: "3.9", abi: "cp39-cp39" },
             { version: "3.10", abi: "cp310-cp310" },
             { version: "3.11", abi: "cp311-cp311" },

diff --git a/README.md b/README.md
@@ -102,7 +102,7 @@ You can add more routes to your API. Check out the routes in [this file](https:/
 
 Robyn is compatible with the following Python versions:
 
-> Python >= 3.8
+> Python >= 3.9
 
 It is recommended to use the latest version of Python for the best performances.
 
@@ -149,7 +149,7 @@ If you still need help to get started, feel free to reach out on our [community
 #### Prerequisites
 
 Before starting, ensure you have the following installed:
-- Python >= 3.8, <= 3.12 , Support for Python 3.13 is coming soon!
+- Python >= 3.9, <= 3.12 , Support for Python 3.13 is coming soon!
 - Rust (latest stable)
 - C compiler (gcc/clang)
 

diff --git a/noxfile.py b/noxfile.py
@@ -3,7 +3,7 @@
 import nox
 
 
-@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12"])
+@nox.session(python=["3.9", "3.10", "3.11", "3.12"])
 def tests(session):
     session.run("pip", "install", "poetry==1.3.0")
     session.run(

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -15,7 +15,6 @@ classifiers = [
   "Operating System :: OS Independent",
   "Topic :: Internet :: WWW/HTTP",
   "Programming Language :: Python :: 3",
-  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
@@ -54,7 +53,7 @@ authors = ["Sanskar Jethi <sansyrox@gmail.com>"]
 
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = "^3.9"
 inquirerpy = "0.3.4"
 maturin = "0.14.12"
 watchdog = "4.0.1"
-Original file line number
+Diff line change
@@ Expand Up / @@ -42,7 +42,6 @@ body: @@
         attributes:
           label: Your Python version (`python --version`)
           options:
-            - 3.8
             - 3.9
             - 3.10
             - 3.11
@@ Expand Down @@