Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to savon 2.3.0, remove namespace workaround #23

Merged
merged 1 commit into from
Jul 30, 2013
+7 −10
Merged

Update to savon 2.3.0, remove namespace workaround #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update to savon 2.3.0, remove namespace workaround
  • Loading branch information
@liggitt
liggitt committed Jul 30, 2013
commit f05fb3d09f804ba550fa026c1e7b3abc027c25ec
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

[full changelog](http://github.com/yolk/valvat/compare/v0.5.0...master)

* Works now with current version of savon gem (2.3.0) (by [liggitt](https://github.com/liggitt))

### 0.5.0 / 2013-07-18

[full changelog](http://github.com/yolk/valvat/compare/v0.4.7...v0.5.0)
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activemodel-3-2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source "http://rubygems.org"

gem "savon", "2.2.0"
gem "savon", "2.3.0"
gem "activemodel", "3.2.13"

gem 'rspec', '>= 2.4.0'
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activemodel-4
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source "http://rubygems.org"

gem "savon", "2.2.0"
gem "savon", "2.3.0"
gem "activemodel", "4.0"

gem 'rspec', '>= 2.4.0'
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/standalone
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source "http://rubygems.org"

gem "savon", "2.2.0"
gem "savon", "2.3.0"

gem 'rspec', '>= 2.4.0'
gem 'fakeweb', '>= 1.3.0'
Expand Down
7 changes: 1 addition & 6 deletions lib/valvat/lookup.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,9 @@ def self.client
# Require Savon only if really needed!
require 'savon' unless defined?(Savon)

# Quiet down HTTPI
HTTPI.log = false

Savon::Client.new(
wsdl: 'http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl',
namespace: 'urn:ec.europa.eu:taxud:vies:services:checkVat:types',
namespaces: {'xmlns:impl'=>'urn:ec.europa.eu:taxud:vies:services:checkVat:types'},
# Quiet down Savon
# Quiet down Savon and HTTPI
log: false
)
end
Expand Down
2 changes: 1 addition & 1 deletion valvat.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Gem::Specification.new do |s|
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
s.require_paths = ["lib"]

s.add_dependency 'savon', '>=2.2.0'
s.add_dependency 'savon', '>=2.3.0'

s.add_development_dependency 'rspec', '>= 2.4.0'
s.add_development_dependency 'guard-rspec', '>=0.1.9'
Expand Down