Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issue in db driver to set delay job #208

Closed
wants to merge 1 commit into from
Closed

resolve issue in db driver to set delay job #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/drivers/db/Queue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public function init()
*/
public function run($repeat, $delay = 0)
{
$delay = intval($delay);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(int) $delay

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO it is wrong way. $delay param comes from console command as timeout option:

yii2-queue/src/drivers/db/Command.php

Lines 66 to 69 in a97007c

public function actionListen($timeout = 3)
{
return $this->queue->run(true, $timeout);
}

I think, it should be made as timeout param validation:

    public function actionListen($timeout = 3)
    {
        if (!is_numeric($timeout)) {
            throw new \yii\console\Exception('Timeout must be numeric.');
        }
        if ($timeout < 1) {
            throw new \yii\console\Exception('Timeout must be greater that zero.');
        }

        return $this->queue->run(true, $timeout);
    }

return $this->runWorker(function (LoopInterface $loop) use ($repeat, $delay) {
while ($loop->canContinue()) {
if ($payload = $this->reserve()) {
Expand Down Expand Up @@ -250,4 +251,4 @@ private function moveExpired()
}

private $reserveTime;
}
}