Fixed a bug when looking for fields by their name

yayashanzei · Jul 7, 2011 · 9d4a0f3 · 9d4a0f3
1 parent 209f19a
commit 9d4a0f3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/library/DrSlump/Protobuf/Descriptor.php b/library/DrSlump/Protobuf/Descriptor.php
@@ -73,9 +73,9 @@ public function getFieldByName($name)
 
         // Loop thru all fields to find it
         foreach ($this->fields as $tag=>$field) {
-            // Build the cache map
-            $this->names[$name] = $tag;
             if ($name === $field->getName()) {
+                // Cache it for next calls
+                $this->names[$name] = $tag;
                 return $field;
             }
         }