Embedded proguard.txt file to AAR library which should get rid of Cla…

…ssNotFoundExceptions automatically
yasirkula · Apr 12, 2021 · 3776f3d · 3776f3d
1 parent 559bb87
commit 3776f3d
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 16 deletions.
diff --git a/.github/AAR Source (Android)/proguard.txt b/.github/AAR Source (Android)/proguard.txt
@@ -0,0 +1 @@
+-keep class com.yasirkula.unity.* { *; }
diff --git a/.github/README.md b/.github/README.md
@@ -74,7 +74,7 @@ After building your project, verify that NativeShare's `<provider ... />` tag is
 
 - **Can't share, it says "java.lang.ClassNotFoundException: com.yasirkula.unity.NativeShare" in Logcat**
 
-If your project uses ProGuard, try adding the following line to ProGuard filters: `-keep class com.yasirkula.unity.* { *; }`
+If you are sure that your plugin is up-to-date, then enable **Custom Proguard File** option from *Player Settings* and add the following line to that file: `-keep class com.yasirkula.unity.* { *; }`
 
 ## EXAMPLE CODE
 

diff --git a/Plugins/NativeShare/Android/NativeShare.aar b/Plugins/NativeShare/Android/NativeShare.aar
diff --git a/Plugins/NativeShare/Editor/NSPostProcessBuild.cs b/Plugins/NativeShare/Editor/NSPostProcessBuild.cs
@@ -1,7 +1,7 @@
-using System.IO;
+#if UNITY_IOS
+using System.IO;
 using UnityEditor;
 using UnityEngine;
-#if UNITY_IOS
 using UnityEditor.Callbacks;
 using UnityEditor.iOS.Xcode;
 #endif
@@ -13,17 +13,6 @@ public class NSPostProcessBuild
 		private const bool ENABLED = true;
 		private const string PHOTO_LIBRARY_USAGE_DESCRIPTION = "The app requires access to Photos to save media to it.";
 
-		[InitializeOnLoadMethod]
-		public static void ValidatePlugin()
-		{
-			string jarPath = "Assets/Plugins/NativeShare/Android/NativeShare.jar";
-			if( File.Exists( jarPath ) )
-			{
-				Debug.Log( "Deleting obsolete " + jarPath );
-				AssetDatabase.DeleteAsset( jarPath );
-			}
-		}
-
 #if UNITY_IOS
 #pragma warning disable 0162
 		[PostProcessBuild]

diff --git a/Plugins/NativeShare/README.txt b/Plugins/NativeShare/README.txt
@@ -35,7 +35,7 @@ It is just not possible to share an image/file with text/subject on some apps (e
 After building your project, verify that NativeShare's "<provider ... />" tag is inserted in-between the "<application>...</application>" tags of PROJECT_PATH/Temp/StagingArea/AndroidManifest.xml. If not, please contact me.
 
 - Can't share, it says "java.lang.ClassNotFoundException: com.yasirkula.unity.NativeShare" in Logcat
-If your project uses ProGuard, try adding the following line to ProGuard filters: -keep class com.yasirkula.unity.* { *; }
+If you are sure that your plugin is up-to-date, then enable "Custom Proguard File" option from Player Settings and add the following line to that file: -keep class com.yasirkula.unity.* { *; }
 
 4. SCRIPTING API
 Simply create a new NativeShare object and customize it by chaining the following functions as you like:

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "com.yasirkula.nativeshare",
   "displayName": "Native Share",
-  "version": "1.3.10",
+  "version": "1.4.0",
   "documentationUrl": "https://github.com/yasirkula/UnityNativeShare",
   "changelogUrl": "https://github.com/yasirkula/UnityNativeShare/releases",
   "licensesUrl": "https://github.com/yasirkula/UnityNativeShare/blob/master/LICENSE.txt",