Trailing and leading quotes #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
Feb 9, 2020
| args.foo.should.equal('-hello world') | ||
| args.bar.should.equal('--goodnight moon') | ||
| const args2 = parser(['--foo', '\\-hello world', '--bar=--goodnight moon']) |
There was a problem hiding this comment.
I don't love the \\ syntax, is there prior art this is based on?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #201
Currently trailing and leading quotes are removed, this applies to
stringand also tostring[]input.One (main?) reason for this:
--arg "--option"if user needs
--optionto be handled as value (no option), he wraps the value into quotes which are removed by yargs-parser later on ==>{ _: [], arg: '--option' }Problem: each and every tl-quotes are removed.
Description of change
This is a delicate topic, so the following is a proposition.
stringinput andstring[]input.string: there are good reasons to remove tl-quotes, as does eg Bash.string[]: we never remove any tl-quotes.[ '--arg', '\\--option' ]==>{ _: [], arg: '--option' }BREAKING CHANGE