Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making LookBackQuery more extensible #1182

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Making LookBackQuery more extensible #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59b16ef
Making LookBackQuery more extensible
Jun 8, 2021
9077688
add changelog
Jun 8, 2021
a4809b2
Merge branch 'master' into making-LookbackQuery-more-extensible
michael-mclawhorn Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ Current
### Added:

### Changed:
- [Make LookBackQuery Extensible](https://github.com/yahoo/fili/issues/1182)
* Make field and constructor less private

- [Make GroupBy Query Extensible](https://github.com/yahoo/fili/issues/1181)
* Make field less private
Expand Down
10 changes: 5 additions & 5 deletions fili-core/src/main/java/com/yahoo/bard/webservice/druid/model/query/LookbackQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@
public class LookbackQuery extends AbstractDruidAggregationQuery<LookbackQuery> {

@JsonInclude(JsonInclude.Include.NON_NULL)
private final Having having;
protected final Having having;

@JsonInclude(JsonInclude.Include.NON_NULL)
private final LimitSpec limitSpec;
protected final LimitSpec limitSpec;

@JsonInclude(JsonInclude.Include.NON_NULL)
private final Collection<String> lookbackPrefixes;
protected final Collection<String> lookbackPrefixes;

private final Collection<Period> lookbackOffsets;
protected final Collection<Period> lookbackOffsets;

/**
* Constructor.
Expand Down Expand Up @@ -155,7 +155,7 @@ public LookbackQuery(
* @param limitSpec Limit spec to apply to the result query
* @param virtualColumns Virtual columns for the query
*/
private LookbackQuery(
protected LookbackQuery(
DataSource dataSource,
Granularity granularity,
Filter filter,
Expand Down