config/commands.py: fix bulkrename on OSX 10.8, fixes ranger#136

Thanks to Ingo Lindholm for the fix: http://lists.gnu.org/archive/html/ranger-users/2013-09/msg00001.html
yahkun · Dec 10, 2014 · 7d38194 · 7d38194
1 parent 1897ee5
commit 7d38194
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/ranger/config/commands.py b/ranger/config/commands.py
@@ -793,20 +793,22 @@ def execute(self):
 
         # Create and edit the file list
         filenames = [f.basename for f in self.fm.thistab.get_selection()]
-        listfile = tempfile.NamedTemporaryFile()
+        listfile = tempfile.NamedTemporaryFile(delete=False)
+        listpath = listfile.name
 
         if py3:
             listfile.write("\n".join(filenames).encode("utf-8"))
         else:
             listfile.write("\n".join(filenames))
-        listfile.flush()
-        self.fm.execute_file([File(listfile.name)], app='editor')
-        listfile.seek(0)
+        listfile.close()
+        self.fm.execute_file([File(listpath)], app='editor')
+        listfile = open(listpath, 'r')
         if py3:
             new_filenames = listfile.read().decode("utf-8").split("\n")
         else:
             new_filenames = listfile.read().split("\n")
         listfile.close()
+        os.unlink(listpath)
         if all(a == b for a, b in zip(filenames, new_filenames)):
             self.fm.notify("No renaming to be done!")
             return