Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core bindings to Yrs v0.18 #91

Closed
11 tasks done
LSViana opened this issue Mar 14, 2024 · 2 comments · Fixed by #94
Closed
11 tasks done

Update core bindings to Yrs v0.18 #91

LSViana opened this issue Mar 14, 2024 · 2 comments · Fixed by #94
Assignees
@LSViana
Labels
enhancement New feature or request

Comments

@LSViana
Copy link
Collaborator

LSViana commented Mar 14, 2024 •
edited
Loading

With the release of Yrs v0.18, some core functions changed and should be updated in the library.

  • Replace *_unobserve_*() bindings with call to yunobserve()
  • Remove yxmlelem()
    • Fix unit tests
  • Remove yxmltext()
    • Fix unit tests
  • Remove ybranch_write_transaction()
  • Remove ybranch_read_transaction()
  • Create bindings for YBranchId:
    • ybranch_id()
    • ybranch_get()
    • ybranch_alive()
    • Refers to: Logical pointers #393@y-crdt

All items above include the bindings and unit tests.

Breaking changes

  • Remove Doc.XmlElement()
    • Fix: use Doc.XmlFragment() for root-level types and then create an XmlElement inside of the XmlFragment.
  • Remove Doc.XmlText()
    • Fix: use Doc.XmlFragment() for root-level types and then create an XmlText inside of the XmlFragment.
@LSViana LSViana added the enhancement New feature or request label Mar 14, 2024
@LSViana LSViana self-assigned this Mar 14, 2024
@LSViana
Copy link
Collaborator Author

LSViana commented Mar 14, 2024

@SebastianStehle FYI, I'll work on this.

@SebastianStehle
Copy link
Collaborator

Awesome. I am looking forward to the new branch pointers :)

@LSViana LSViana mentioned this issue Mar 23, 2024
Merged
@LSViana LSViana linked a pull request Mar 23, 2024 that will close this issue
Update core bindings to Yrs v0.18 #94
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LSViana LSViana

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update core bindings to Yrs v0.18 y-crdt/ydotnet
2 participants
@SebastianStehle @LSViana