updated yffi tests

y-crdt · Horusiath · Mar 9, 2024 · Feb 11, 2024 · Feb 15, 2024 · Feb 16, 2024
commit 7d50569ca55416e0c4ad8952fc4b81139ac098bb
diff --git a/tests-ffi/include/libyrs.h b/tests-ffi/include/libyrs.h
@@ -351,12 +351,12 @@ typedef struct YOptions {
 } YOptions;
 
 /**
- * A Yrs document type. Documents are most important units of collaborative resources management.
+ * A Yrs document type. Documents are the most important units of collaborative resources management.
  * All shared collections live within a scope of their corresponding documents. All updates are
- * generated on per document basis (rather than individual shared type). All operations on shared
+ * generated on per-document basis (rather than individual shared type). All operations on shared
  * collections happen via `YTransaction`, which lifetime is also bound to a document.
  *
- * Document manages so called root types, which are top-level shared types definitions (as opposed
+ * Document manages so-called root types, which are top-level shared types definitions (as opposed
  * to recursively nested types).
  */
 typedef YDoc YDoc;
@@ -1114,26 +1114,6 @@ YTransaction *ydoc_read_transaction(YDoc *doc);
  */
 YTransaction *ydoc_write_transaction(YDoc *doc, uint32_t origin_len, const char *origin);
 
-/**
- * Starts a new read-write transaction on a given branches document. All other operations happen in
- * context of a transaction. Yrs transactions do not follow ACID rules. Once a set of operations is
- * complete, a transaction can be finished using `ytransaction_commit` function.
- *
- * Returns `NULL` if read-write transaction couldn't be created, i.e. when another transaction is
- * already opened.
- */
-YTransaction *ybranch_write_transaction(Branch *branch);
-
-/**
- * Starts a new read-only transaction on a given branches document. All other operations happen in
- * context of a transaction. Yrs transactions do not follow ACID rules. Once a set of operations is
- * complete, a transaction can be finished using `ytransaction_commit` function.
- *
- * Returns `NULL` if read-only transaction couldn't be created, i.e. when another read-write
- * transaction is already opened.
- */
-YTransaction *ybranch_read_transaction(Branch *branch);
-
 /**
  * Check if current branch is still alive (returns `Y_TRUE`, otherwise `Y_FALSE`).
  * If it was deleted, this branch pointer is no longer a valid pointer and cannot be used to
@@ -1197,27 +1177,13 @@ Branch *yarray(YDoc *doc,
  */
 Branch *ymap(YDoc *doc, const char *name);
 
-/**
- * Gets or creates a new shared `YXmlElement` data type instance as a root-level type of a given
- * document. This structure can later be accessed using its `name`, which must be a null-terminated
- * UTF-8 compatible string.
- */
-Branch *yxmlelem(YDoc *doc, const char *name);
-
 /**
  * Gets or creates a new shared `YXmlElement` data type instance as a root-level type of a given
  * document. This structure can later be accessed using its `name`, which must be a null-terminated
  * UTF-8 compatible string.
  */
 Branch *yxmlfragment(YDoc *doc, const char *name);
 
-/**
- * Gets or creates a new shared `YXmlText` data type instance as a root-level type of a given
- * document. This structure can later be accessed using its `name`, which must be a null-terminated
- * UTF-8 compatible string.
- */
-Branch *yxmltext(YDoc *doc, const char *name);
-
 /**
  * Returns a state vector of a current transaction's document, serialized using lib0 version 1
  * encoding. Payload created by this function can then be send over the network to a remote peer,

diff --git a/tests-ffi/main.cpp b/tests-ffi/main.cpp
@@ -271,8 +271,9 @@ TEST_CASE("YMap basic") {
 
 TEST_CASE("YXmlElement basic") {
     YDoc* doc = ydoc_new_with_id(1);
-    Branch* xml = yxmlelem(doc, "test");
+    Branch* frag = yxmlfragment(doc, "test");
     YTransaction* txn = ydoc_write_transaction(doc, 0, NULL);
+    Branch* xml = yxmlelem_insert_elem(frag, txn, 0, "div");
 
     // XML attributes API
     yxmlelem_insert_attr(xml, txn, "key1", "value1");
@@ -832,8 +833,9 @@ void yxmltext_test_clean(YXmlTextEventTest* t) {
 
 TEST_CASE("YXmlText observe") {
     YDoc* doc = ydoc_new_with_id(1);
-    Branch* txt = yxmltext(doc, "test");
+    Branch* frag = yxmlfragment(doc, "test");
     YTransaction* txn = ydoc_write_transaction(doc, 0, NULL);
+    Branch* txt = yxmlelem_insert_text(frag, txn, 0);
 
     YXmlTextEventTest* t = yxmltext_event_test_new();
     YSubscription* sub = yxmltext_observe(txt, (void*)t, &yxmltext_test_observe);
@@ -926,8 +928,9 @@ void yxml_test_clean(YXmlEventTest* t) {
 
 TEST_CASE("YXmlElement observe") {
     YDoc* doc = ydoc_new_with_id(1);
-    Branch* xml = yxmlelem(doc, "test");
+    Branch *frag = yxmlfragment(doc, "test");
     YTransaction* txn = ydoc_write_transaction(doc, 0, NULL);
+    Branch* xml = yxmlelem_insert_elem(frag, txn, 0, "div");
 
     YXmlEventTest* t = yxml_event_test_new();
     YSubscription* sub = yxmlelem_observe(xml, (void*)t, &yxml_test_observe);