init work: make the public API clear

xxchan · xxchan · Feb 26, 2023 · Feb 26, 2023 · Apr 9, 2023 · Feb 26, 2023
commit fb5b2fe2be03997469db74f8abf3ad5d0c53e374
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/fluvio-smartengine/Cargo.toml b/crates/fluvio-smartengine/Cargo.toml
@@ -12,11 +12,12 @@ description = "The official Fluvio SmartEngine"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [features]
-engine = ["wasmtime"]
+engine = ["wasmedge-engine", "wasmtime-engine"]
 wasi = ["wasmtime-wasi", "engine"]
 transformation = ["serde_json", "serde_yaml"]
 default = ["engine"]
-
+wasmtime-engine = ["wasmtime", "wasmtime-wasi"]
+wasmedge-engine = ["wasmedge-sdk"]
 
 [dependencies]
 tracing ={ workspace = true }
@@ -27,6 +28,7 @@ wasmtime-wasi = { version = "7.0.0", optional = true }
 serde = { version = "1", features = ['derive'] }
 serde_json = { version = "1.0", optional = true }
 serde_yaml = { version = "0.9", default-features = false, optional = true }
+wasmedge-sdk = { version = "0.7", optional = true }
 
 cfg-if = "1.0.0"
 derive_builder = { workspace = true }

diff --git a/crates/fluvio-smartengine/src/config.rs b/crates/fluvio-smartengine/src/config.rs
@@ -0,0 +1,73 @@
+use derive_builder::Builder;
+use fluvio_smartmodule::dataplane::smartmodule::{SmartModuleExtraParams};
+
+const DEFAULT_SMARTENGINE_VERSION: i16 = 17;
+
+/// Initial seed data to passed, this will be send back as part of the output
+#[derive(Debug, Clone)]
+#[non_exhaustive]
+pub enum SmartModuleInitialData {
+    None,
+    Aggregate { accumulator: Vec<u8> },
+}
+
+impl SmartModuleInitialData {
+    pub fn with_aggregate(accumulator: Vec<u8>) -> Self {
+        Self::Aggregate { accumulator }
+    }
+}
+
+impl Default for SmartModuleInitialData {
+    fn default() -> Self {
+        Self::None
+    }
+}
+
+/// SmartModule configuration
+#[derive(Builder)]
+pub struct SmartModuleConfig {
+    #[builder(default, setter(strip_option))]
+    pub(crate) initial_data: SmartModuleInitialData,
+    #[builder(default)]
+    pub(crate) params: SmartModuleExtraParams,
+    // this will be deprecated in the future
+    #[builder(default, setter(into, strip_option))]
+    pub(crate) version: Option<i16>,
+}
+
+impl SmartModuleConfigBuilder {
+    /// add initial parameters
+    pub fn param(&mut self, key: impl Into<String>, value: impl Into<String>) -> &mut Self {
+        let mut new = self;
+        let mut params = new.params.take().unwrap_or_default();
+        params.insert(key.into(), value.into());
+        new.params = Some(params);
+        new
+    }
+}
+
+impl SmartModuleConfig {
+    pub fn builder() -> SmartModuleConfigBuilder {
+        SmartModuleConfigBuilder::default()
+    }
+
+    pub(crate) fn version(&self) -> i16 {
+        self.version.unwrap_or(DEFAULT_SMARTENGINE_VERSION)
+    }
+}
+
+#[cfg(feature = "transformation")]
+impl From<crate::transformation::TransformationStep> for SmartModuleConfig {
+    fn from(step: crate::transformation::TransformationStep) -> Self {
+        Self {
+            initial_data: SmartModuleInitialData::None,
+            params: step
+                .with
+                .into_iter()
+                .map(|(k, v)| (k, v.into()))
+                .collect::<std::collections::BTreeMap<String, String>>()
+                .into(),
+            version: None,
+        }
+    }
+}