Skip to content

Commit

Permalink
fixed an issue with cli_args for selenium
Browse files Browse the repository at this point in the history
  • Loading branch information
beatfactor committed May 25, 2014
1 parent 565627d commit 7be3c86
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ UI automated testing framework powered by [Node.js](http://nodejs.org/). It uses

***

#### [Homepage](http://nightwatchjs.org) | [Developer Guide](http://nightwatchjs.org/guide) | [API Reference](http://nightwatchjs.org/api)
#### [Homepage](http://nightwatchjs.org) | [Developer Guide](http://nightwatchjs.org/guide) | [API Reference](http://nightwatchjs.org/api)

### Selenium WebDriver standalone server
Nightwatch works with the Selenium standalone server so the first thing you need to do is download the selenium server jar file `selenium-server-standalone-2.x.x.jar` from the Selenium releases page:
Nightwatch works with the Selenium standalone server so the first thing you need to do is download the selenium server jar file `selenium-server-standalone-2.x.x.jar` from the Selenium releases page:
**http://selenium-release.storage.googleapis.com/index.html**

### Install Nightwatch
Expand All @@ -25,7 +25,10 @@ $ npm install
The tests for nightwatch are written using [nodeunit](https://github.com/caolan/nodeunit) as the test framework. To run the nodeunit tests do:
```sh
$ npm test
```
```

### Discuss
In addition to [Twitter](https://twitter.com/nightwatchjs), the [Mailing List/Google Group](https://groups.google.com/forum/#!forum/nightwatchjs) is also available for Nightwatch related discussions.

### Setup Guides
Browser specific setup and usage guides along with debugging instructions can be found on the [**Wiki**](https://github.com/beatfactor/nightwatch/wiki).
3 changes: 2 additions & 1 deletion bin/_clirunner.js
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ CliRunner.prototype = {
}
this.settings.parallelMode = this.parallelMode;
var self = this;

Selenium.startServer(this.settings, function(error, child, error_out, exitcode) {
if (error) {
if (self.test_settings.output) {
Expand Down Expand Up @@ -356,7 +357,7 @@ CliRunner.prototype = {
if (!this.manageSelenium) {
return this;
}
this.settings.selenium.cli_args = {};
this.settings.selenium.cli_args = this.settings.selenium.cli_args || {};

var deprecationNotice = function(propertyName, newSettingName) {
console.warn(Logger.colors.brown('DEPRECATION NOTICE: Property ' + propertyName + ' is deprecated since v0.5. Please' +
Expand Down

0 comments on commit 7be3c86

Please sign in to comment.