XEP-0054: Updated error cases to be compatible with RFC 6121 #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In section 3.3 of XEP-0054 it is defined that the same error condition MUST be used in both a case: - where a VCard request is addressed to an entity that does not exist, and; - where a VCard request is addressed at an entity for which no VCard is available. RFC 6121 section 8.5.1 defines: > If the user account identified by the 'to' attribute does not exist, how the stanza is processed depends on the stanza type. For an IQ stanza, the server MUST return a `<service-unavailable/>` stanza error to the sender. Prior to this change, both `<service-unavailable/>` and `<item-not-found/>` were offered as suitable conditions to be used in the error scenario defined in section 3.3. For this XEP to be more compatible with RFC 6121, only <service-unavailable> can be used. This commit drops the `<item-not-found>` condition from the scenario, and elevates usage of `<service-unavailable>` to a MUST. It adds a note on backwards compatibility.
guusdk
force-pushed
the
xep-0054_error-handling
branch
from
4546d69
to
507e6d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In section 3.3 of XEP-0054 it is defined that the same error condition MUST be used in both a case:
RFC 6121 section 8.5.1 defines:
Prior to this change, both
<service-unavailable/>and<item-not-found/>were offered as suitable conditions to be used in the error scenario defined in section 3.3. For this XEP to be more compatible with RFC 6121, only<service-unavailable>can be used.This commit drops the
<item-not-found>condition from the scenario, and elevates usage of to a MUST. It adds a note on backwards compatibility.