Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0372: Document how to reference non-body elements #1102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcbrand
Copy link
Contributor

@jcbrand jcbrand commented Aug 25, 2021

Documents how the 'anchor' attribute can be used to disambiguate which text-containing element is being referred to.

I brought this up in the standards list here: https://mail.jabber.org/pipermail/standards/2021-August/038504.html

@Kev Please let me know if you agree with this approach.

@horazont
Copy link
Contributor

@Kev Please post your response to the mailing list thread instead of here to keep the technical discussions off github… I also replied there, @jcbrand.

@horazont horazont added Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. Needs List Discussion The change should be discussed on-list. labels Sep 7, 2021
xep-0372.xml Outdated
begin='6'
end='13'
type='mention'
anchor='subject'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the mailing list your example used fragment URIs so anchor='#subject' - was the change here deliberate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this was a mistake. I've added the # now, thanks.

@jcbrand jcbrand force-pushed the jcbrand/xep-0372-anchor-fragment branch from 0fd35e7 to 832894d Compare October 11, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. Needs List Discussion The change should be discussed on-list.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants