fix: signal channel should be buffered (#2)

* fix: signal channel should be buffered
xonvanetta · Sep 1, 2021 · 59aa4ed · 59aa4ed
1 parent eff19b6
commit 59aa4ed
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/pkg/shutdown/shutdown.go b/pkg/shutdown/shutdown.go
@@ -11,7 +11,7 @@ func init() {
 	signal.Notify(signals, os.Interrupt, syscall.SIGINT, syscall.SIGTERM)
 }
 
-var signals = make(chan os.Signal)
+var signals = make(chan os.Signal, 1)
 
 func Chan() <-chan struct{} {
 	shutdown := make(chan struct{})

diff --git a/pkg/shutdown/shutdown_test.go b/pkg/shutdown/shutdown_test.go
@@ -9,6 +9,24 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+func TestBuffered(t *testing.T) {
+	process, err := os.FindProcess(os.Getpid())
+	assert.NoError(t, err)
+
+	go func() {
+		time.Sleep(time.Millisecond)
+		err := process.Signal(os.Interrupt)
+		assert.NoError(t, err)
+	}()
+
+	time.Sleep(time.Millisecond * 10)
+	select {
+	case <-Chan():
+	case <-time.After(time.Second):
+		assert.Fail(t, "shutdown never happened")
+	}
+}
+
 func TestChan(t *testing.T) {
 	testShutdown(t, Chan())
 }