Skip to content

Commit

Permalink
Merge pull request grpc#3081 from ctiller/under-pressure
Browse files Browse the repository at this point in the history
Up asan/tsan timeouts - they need it
  • Loading branch information
dgquintas committed Aug 26, 2015
2 parents 33c9c1f + b2ea0b9 commit 69d500d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 0 additions & 1 deletion tools/run_tests/jobset.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ def __init__(self, spec, bin_hash, newline_on_success, travis, add_env, xml_repo
for k, v in add_env.iteritems():
env[k] = v
self._start = time.time()
print spec.cmdline
self._process = subprocess.Popen(args=spec.cmdline,
stderr=subprocess.STDOUT,
stdout=self._tempfile,
Expand Down
8 changes: 5 additions & 3 deletions tools/run_tests/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,14 @@ def platform_string():
# SimpleConfig: just compile with CONFIG=config, and run the binary to test
class SimpleConfig(object):

def __init__(self, config, environ=None):
def __init__(self, config, environ=None, timeout_seconds=5*60):
if environ is None:
environ = {}
self.build_config = config
self.allow_hashing = (config != 'gcov')
self.environ = environ
self.environ['CONFIG'] = config
self.timeout_seconds = timeout_seconds

def job_spec(self, cmdline, hash_targets, shortname=None, environ={}):
"""Construct a jobset.JobSpec for a test under this config
Expand All @@ -96,6 +97,7 @@ def job_spec(self, cmdline, hash_targets, shortname=None, environ={}):
return jobset.JobSpec(cmdline=cmdline,
shortname=shortname,
environ=actual_environ,
timeout_seconds=self.timeout_seconds,
hash_targets=hash_targets
if self.allow_hashing else None)

Expand Down Expand Up @@ -354,11 +356,11 @@ def __str__(self):
_CONFIGS = {
'dbg': SimpleConfig('dbg'),
'opt': SimpleConfig('opt'),
'tsan': SimpleConfig('tsan', environ={
'tsan': SimpleConfig('tsan', timeout_seconds=10*60, environ={
'TSAN_OPTIONS': 'suppressions=tools/tsan_suppressions.txt:halt_on_error=1:second_deadlock_stack=1'}),
'msan': SimpleConfig('msan'),
'ubsan': SimpleConfig('ubsan'),
'asan': SimpleConfig('asan', environ={
'asan': SimpleConfig('asan', timeout_seconds=7*60, environ={
'ASAN_OPTIONS': 'detect_leaks=1:color=always:suppressions=tools/tsan_suppressions.txt',
'LSAN_OPTIONS': 'report_objects=1'}),
'asan-noleaks': SimpleConfig('asan', environ={
Expand Down

0 comments on commit 69d500d

Please sign in to comment.