Update grid_ufunc.py #636
Open
Update grid_ufunc.py #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Hi @liu-ran, thank you for using xgcm and contributing. To help the developers in accepting this PR, can you first open an issue describing what the bug was? |
|
Hi @dhruvbalwada ,thanks for your guidance! I will try to follow your instructions although I don't have much experience on this. |
|
No worries about starting out @liu-ran! Indeed having a Minimal Reproducible Example in a separate issue would be very helpful to guide any improvement. If you could work on that (and feel free to tag me), we can take things from there, and return here for a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I just found a bug in the xgcm when calculating the vector from the native LLC grid. My xgcm version is 0.8.1 xarray 2024.2.0 After I fixed the bug, now the xgcm can work well.
Best,
Ran
pre-commit run --all-fileswhats-new.rstapi.rst