Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black version in pre-commit #472

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Apr 18, 2022


- repo: https://github.com/python/black
rev: 21.5b1
- repo: https://github.com/psf/black
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why we had python/black here? I believe that has just been renamed, as the link points to ...psf/black now.

@jbusecke
Copy link
Contributor Author

Ughh this line here has given me all kinds of grief...

 f2 = f2.assign_coords(h=f2.y ** 2)

I do not understand how it passes locally, but not here. Not really worth to dig deep for this. Ill change it manually.

Copy link
Contributor Author

@jbusecke jbusecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once the tests pass I would merge this.

@jbusecke jbusecke merged commit a21d886 into master Apr 18, 2022
@jbusecke jbusecke mentioned this pull request Apr 18, 2022
2 tasks
@TomNicholas TomNicholas deleted the hotfix-pre-commit-black branch April 20, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] black issue in the pre-commit CI
1 participant