Asterisk can match an empty string too.

xavierd · Jul 16, 2017 · e553e00 · e553e00
1 parent 9e36784
commit e553e00
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/dulwich/ignore.py b/dulwich/ignore.py
@@ -60,7 +60,7 @@ def translate(pat):
         c = pat[i:i+1]
         i = i+1
         if c == b'*':
-            res = res + b'[^/]+'
+            res = res + b'[^/]*'
         elif c == b'?':
             res = res + b'.'
         elif c == b'[':

diff --git a/dulwich/tests/test_ignore.py b/dulwich/tests/test_ignore.py
@@ -41,6 +41,7 @@
 
 POSITIVE_MATCH_TESTS = [
     (b"foo.c", b"*.c"),
+    (b".c", b"*.c"),
     (b"foo/foo.c", b"*.c"),
     (b"foo/foo.c", b"foo.c"),
     (b"foo.c", b"/*.c"),
@@ -66,9 +67,9 @@
 
 
 TRANSLATE_TESTS = [
-    (b"*.c", b'(?ms)(.*/)?[^/]+\\.c/?\\Z'),
+    (b"*.c", b'(?ms)(.*/)?[^/]*\\.c/?\\Z'),
     (b"foo.c", b'(?ms)(.*/)?foo\\.c/?\\Z'),
-    (b"/*.c", b'(?ms)[^/]+\\.c/?\\Z'),
+    (b"/*.c", b'(?ms)[^/]*\\.c/?\\Z'),
     (b"/foo.c", b'(?ms)foo\\.c/?\\Z'),
     (b"foo.c", b'(?ms)(.*/)?foo\\.c/?\\Z'),
     (b"foo.[ch]", b'(?ms)(.*/)?foo\\.[ch]/?\\Z'),