Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GIF compression #748

Merged
merged 10 commits into from
Jul 17, 2020
Merged

Add GIF compression #748

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
19d08c4
First pass at adding compression
amorriscode Nov 2, 2019
0251993
Remove giflossy
amorriscode Feb 26, 2020
979a31a
Properly handle compression
amorriscode Feb 26, 2020
1b90465
Fix linting issues
amorriscode Mar 31, 2020
ad0a4ff
Improve readability of code and setting description
amorriscode Jun 23, 2020
490a8a4
Lower lossiness of lossy compression
amorriscode Jun 23, 2020
89deaab
Fix invalid paremeter
amorriscode Jul 17, 2020
962aeee
Update subtitle for lossy compression setting
amorriscode Jul 17, 2020
1ff3679
Add mock for settings
amorriscode Jul 17, 2020
3d04f1e
Adjust subtitle based on suggestion
amorriscode Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve readability of code and setting description
  • Loading branch information
@amorriscode
amorriscode committed Jul 17, 2020
commit ad0a4ff3ab0f600754f3ac9435f581f29ef0dc0e
2 changes: 1 addition & 1 deletion main/convert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ const convertToGif = PCancelable.fn(async (options, onCancel) => {
]);

return compress(options.outputPath, options, [
karaggeorge marked this conversation as resolved.
Show resolved Hide resolved
'-b',
'--batch',
options.outputPath
]);
});
Expand Down
2 changes: 1 addition & 1 deletion renderer/components/preferences/categories/general.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class General extends React.Component {
key="lossyCompression"
parentItem
title="Lossy compression"
subtitle="Use lossy compression for gifs"
subtitle="Compress GIFs with lossy compression if you prefer small file size over quality"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could make it clearer that the quality is only slightly reduced.

>
<Switch
tabIndex={tabIndex}
Expand Down