Use gutenberg translation files locally #536

Tug · 2019-02-04T19:19:10Z

Addresses part of #203
Requires wordpress-mobile/WordPress-Android#9249
Requires wordpress-mobile/WordPress-iOS#11056

Requires those 2 PRs to be merged first so the gb-mobile strings get translated in WPiOS and WPAndroid glotpress:
wordpress-mobile/WordPress-iOS#10999
wordpress-mobile/WordPress-Android#9214

Summary

This PR adds a local script that downloads gutenberg translation files and cache them locally.

Testing Instructions

Load this branch locally
Run yarn start and check that translation files are downloaded in i18n-cache/data and that a file is generated at i18n-cache/index.native.js
Edit src/app/App.js and replace setLocaleData( getTranslation( locale ) ); with setLocaleData( getTranslation( 'es' ) );
Reload the app and check that parts of the app have been translated to Spanish
Reset the code and run yarn wpandroid or yarn ios
Change the app or the phone language
Check that gutenberg editor is translated

A PR in both https://github.com/wordpress-mobile/WordPress-iOS and https://github.com/wordpress-mobile/WordPress-Android will be necessary to pass the new locale parameter.

…berg

hypest · 2019-02-21T09:01:43Z

i18n-cache/index.js

+	'tr', // Turkish
+	'zh-cn', // Chinese (China)
+	'zh-tw', // Chinese (Taiwan)
+];


Heh, can we add el too? I'm biased :P

hypest · 2019-02-21T13:17:54Z

src/app/App.js

@@ -1,31 +1,63 @@
 /** @flow
 * @format */
+
+import '../globals';


Do we need to import globals here too? 🤔

Shouldn't be required, removing it 👍

hypest · 2019-02-21T13:27:04Z

src/app/App.js

-};
+	setLocale( locale: ?string ) {
+		const translationsFromParentApp = this.props.translations || {};
+		const translations = Object.assign( {}, translationsFromParentApp, getTranslation( locale ) );


Hmm, I'm thinking, how about giving the WP apps priority here? Like, if there's a conflict between what the parent sends and what Gutenberg has then let's give the parent priority. That would also give us the ability to have each mobile platform decide to overwrite a string, for whatever reason (e.g. platform guidelines). WDYT?

It sounds sane. The only thing I'm afraid of though is mixing english and an other language in the case of using a language which is supported by the app but not by gutenberg for instance.

If you don't think it's a problem I can give the parent app priority

Hmm, won't that be true the other way too? Like, if some strings are translated by GB but the native specific ones are not, right?

Yeah, I went with your approach in the end and decided to mix both and give priority to the parent app 👍

All in all, I think that giving priority to the native side strings should be a good start. We can revise if we see it be problematic.

I checked the current Spanish translations in both apps and Gutenberg for common strings, and everything seems pretty consistent. The only difference I've spotted that's perhaps relevant is how media library is translated, and it makes sense that we're consistent with the app translation, so good call 😁

pinarol · 2019-02-21T14:28:24Z

hey @etoledom 👋 it'd be ok if you just review the iOS bridge and iOS example app changes

etoledom

The iOS part looks good on the example app! ✅

etoledom · 2019-02-21T15:10:32Z

ios/gutenberg/GutenbergViewController.swift

@@ -116,6 +116,15 @@ extension GutenbergViewController: GutenbergBridgeDelegate {
 }

 extension GutenbergViewController: GutenbergBridgeDataSource {
+
+    func gutenbergLocale() -> String? {
+        return "en"


We could send the device locale directly. Since is the example app is not a blocker, but it would nice to test translations just by changing the device language in the run settings for fast tests.

Suggested change

return "en"

return Locale.preferredLanguages.first ?? "en"

pinarol

LGTM!

hypest

LGTM!

hypest · 2019-02-21T18:21:04Z

Even though this PR is ready to merge, please don't merge until the PRs in the parent apps are also ready to merge. cc @Tug @pinarol @koke

koke · 2019-02-21T21:05:52Z

When I run yarn install I'm seeing this

Could not find translation file https://widgets.wp.com/languages/gutenberg/en-ca.json
Could not find translation file https://widgets.wp.com/languages/gutenberg/en-au.json
Could not find translation file https://widgets.wp.com/languages/gutenberg/nb.json

Is that expected?

hypest · 2019-02-21T21:16:57Z

Yes, I think I remember @Tug mentioning this to me on a voice chat that not all locales supported by the apps (where the original list of locales came from) are supported by Gutenberg @koke .

We merged wordpress-mobile/gutenberg-mobile#536 and recreated the bundles

koke · 2019-02-21T21:39:38Z

I was mentioning this to Tug on slack, that Norwegian seems to be on Glotpress so maybe this is more of a WordPress.com think. It might be a good idea to switch to fetching from glotpress directly before the release. This seems to download translations but I haven't tested if it's the same JSON format:

curl "https://translate.wordpress.org/projects/wp-plugins/gutenberg/dev/nb/default/export-translations?format=json"

Download translation files and cache them locally

aedae19

Tug added the [Status] Not Ready For Review label Feb 4, 2019

Tug self-assigned this Feb 4, 2019

Tug added 7 commits February 5, 2019 10:15

Add node-fetch dev dependency and remove unnecessary lodash require

d7fdc99

Generate mobile version of the i18n-cache module on boot

aacee9f

Remove default locale value for param

9d9bcc6

Merge remote-tracking branch 'origin/develop' into add/i18n-cache

06201a8

Add glue code for ios

516a653

Add glue code for android

c00afae

Revert changes in RNReactNativeGutenbergBridgeModule.java

350cc4b

Tug requested a review from hypest February 5, 2019 14:06

Tug added 4 commits February 5, 2019 15:08

Run i18n-cache update before running tests

139f6b8

Fix eslint checks

57a390a

Remove redundant condition

1c306aa

Refresh i18n translation files before bundling

d1dd1c8

Tug added [Type] Enhancement Improves a current area of the editor [Status] Needs iOS Dev [Status] Needs Android Dev and removed [Status] Not Ready For Review labels Feb 5, 2019

Tug added 6 commits February 11, 2019 14:20

Add yarn makepot command to make pot file

08b4c1a

Merge remote-tracking branch 'origin/develop' into add/i18n-cache

f4335c2

Test receiving translations prop

977dd6a

Merge the translations from the parent app with those from from guten…

c6b2d9f

…berg

Fix imports

95b589f

fix pot name

be03454

koke mentioned this pull request Feb 14, 2019

i18n support #203

Closed

Tug and others added 3 commits February 14, 2019 18:30

Pass the locale down to gutenberg-mobile

ee00a75

Print the current locale and the translations in the console

b715c4d

Add translations to initial props on iOS bridge

b9a9b90

pinarol mentioned this pull request Feb 15, 2019

Send all translations to gutenberg-mobile wordpress-mobile/WordPress-iOS#11056

Merged

1 task

Update iOS translation values as arrays

bb606d4

Tug mentioned this pull request Feb 19, 2019

Send all translations to gutenberg-mobile wordpress-mobile/WordPress-Android#9249

Merged

Merge remote-tracking branch 'origin/develop' into add/i18n-cache

9fb9495

hypest reviewed Feb 21, 2019

View reviewed changes

Tug added 5 commits February 21, 2019 10:02

Run yarn prebundle before bundle:android and bundle:ios instead

640ea3e

Run yarn i18n-cache on postinstall

6f46ca1

Merge remote-tracking branch 'origin/develop' into add/i18n-cache

b289532

Add Greek support

1582c05

Fallback to a locale without a regional code if not supported

2d269ae

hypest reviewed Feb 21, 2019

View reviewed changes

Fix lint issue

2eae55c

hypest reviewed Feb 21, 2019

View reviewed changes

Tug added 2 commits February 21, 2019 14:36

Remove unnecessary import

65757d7

Give priority to the parent app translations

d4aa448

pinarol requested a review from etoledom February 21, 2019 14:27

etoledom approved these changes Feb 21, 2019

View reviewed changes

Default to the device language for the example app

ab98cf4

pinarol approved these changes Feb 21, 2019

View reviewed changes

hypest approved these changes Feb 21, 2019

View reviewed changes

koke merged commit a24a46c into develop Feb 21, 2019

koke deleted the add/i18n-cache branch February 21, 2019 21:01

koke restored the add/i18n-cache branch February 21, 2019 21:02

koke deleted the add/i18n-cache branch February 21, 2019 21:02

koke mentioned this pull request Feb 21, 2019

Updated bundles #641

Merged

koke added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Feb 21, 2019

Update gutenberg-mobile ref to latest develop

8cde879

We merged wordpress-mobile/gutenberg-mobile#536 and recreated the bundles

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use gutenberg translation files locally #536

Use gutenberg translation files locally #536

Tug commented Feb 4, 2019 •

edited

Loading

hypest Feb 21, 2019

hypest Feb 21, 2019

Tug Feb 21, 2019

hypest Feb 21, 2019

Tug Feb 21, 2019

hypest Feb 21, 2019

Tug Feb 21, 2019

hypest Feb 21, 2019

koke Feb 21, 2019

pinarol commented Feb 21, 2019 •

edited

Loading

etoledom left a comment

etoledom Feb 21, 2019

pinarol left a comment

hypest left a comment

hypest commented Feb 21, 2019

koke commented Feb 21, 2019 •

edited

Loading

hypest commented Feb 21, 2019

koke commented Feb 21, 2019

Use gutenberg translation files locally #536

Use gutenberg translation files locally #536

Conversation

Tug commented Feb 4, 2019 • edited Loading

Summary

Testing Instructions

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pinarol commented Feb 21, 2019 • edited Loading

etoledom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pinarol left a comment

Choose a reason for hiding this comment

hypest left a comment

Choose a reason for hiding this comment

hypest commented Feb 21, 2019

koke commented Feb 21, 2019 • edited Loading

hypest commented Feb 21, 2019

koke commented Feb 21, 2019

Tug commented Feb 4, 2019 •

edited

Loading

pinarol commented Feb 21, 2019 •

edited

Loading

koke commented Feb 21, 2019 •

edited

Loading