Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TipKit FF #23906

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove TipKit FF #23906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions WordPress/Classes/Utility/BuildInformation/FeatureFlag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ enum FeatureFlag: Int, CaseIterable {
case googleDomainsCard
case voiceToContent
case authenticateUsingApplicationPassword
case tipKit
case newGutenberg
case newGutenbergThemeStyles
case newGutenbergPlugins
Expand Down Expand Up @@ -42,8 +41,6 @@ enum FeatureFlag: Int, CaseIterable {
return AppConfiguration.isJetpack && BuildConfiguration.current ~= [.localDeveloper, .a8cBranchTest]
case .authenticateUsingApplicationPassword:
return false
case .tipKit:
return true
case .newGutenberg:
return false
case .newGutenbergThemeStyles:
Expand Down Expand Up @@ -83,7 +80,6 @@ extension FeatureFlag {
case .googleDomainsCard: "Google Domains Promotional Card"
case .voiceToContent: "Voice to Content"
case .authenticateUsingApplicationPassword: "Application Passwords for self-hosted sites"
case .tipKit: "TipKit"
case .newGutenberg: "Experimental Block Editor"
case .newGutenbergThemeStyles: "Experimental Block Editor Styles"
case .newGutenbergPlugins: "Experimental Block Editor Plugins"
Expand Down
5 changes: 1 addition & 4 deletions WordPress/Classes/ViewRelated/Tips/AppTips.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Combine

enum AppTips {
static func initialize() {
guard Feature.enabled(.tipKit), #available(iOS 17, *) else { return }
guard #available(iOS 17, *) else { return }
do {
try Tips.configure()
} catch {
Expand Down Expand Up @@ -65,9 +65,6 @@ extension UIViewController {
arrowDirection: UIPopoverArrowDirection? = nil,
actionHandler: ((Tips.Action) -> Void)? = nil
) -> TipObserver? {
guard Feature.enabled(.tipKit) else {
return nil
}
let task = Task { @MainActor [weak self] in
for await shouldDisplay in tip.shouldDisplayUpdates {
if shouldDisplay {
Expand Down
Loading