Cleanup warnings

woocommerce · Dec 24, 2024 · 5e2c4c3 · 5e2c4c3
1 parent 13aa13a
commit 5e2c4c3
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 12 deletions.
diff --git a/WooCommerce/WooCommerceTests/Authentication/EditStoreListViewModelTests.swift b/WooCommerce/WooCommerceTests/Authentication/EditStoreListViewModelTests.swift
@@ -11,8 +11,9 @@ struct EditStoreListViewModelTests {
     @Test func hasChanges_returns_correct_values() {
         // Given
         let availableSites = [site1, site2]
-        let viewModel = EditStoreListViewModel(availableSites: [site1, site2],
-                                               displayedSites: [site1, site2],
+        let displayedSites = [site1, site2]
+        let viewModel = EditStoreListViewModel(availableSites: availableSites,
+                                               displayedSites: displayedSites,
                                                currentlySelectedSite: nil,
                                                onCompletion: {})
 

diff --git a/...CommerceTests/ViewModels/Order Details/Address/LocallyStoredStateNameRetrieverTests.swift b/...CommerceTests/ViewModels/Order Details/Address/LocallyStoredStateNameRetrieverTests.swift
@@ -35,10 +35,10 @@ final class LocallyStoredStateNameRetrieverTests: XCTestCase {
         // Given
         let stateCode = "TS"
         let address = Address.fake().copy(state: stateCode, country: "A different country")
-        let stateOfACountry = StateOfACountry(code: stateCode, name: "Test State")
-        storageManager.insertSampleCountries(readOnlyCountries: [Country(code: "US",
-                                                                         name: "United States",
-                                                                         states: [StateOfACountry(code: stateCode, name: "Testland")])])
+        let stateOfACountry = StateOfACountry(code: stateCode, name: "Testland")
+        storageManager.insertSampleCountries(readOnlyCountries: [
+            Country(code: "US", name: "United States", states: [stateOfACountry])
+        ])
 
         // When/Then
         XCTAssertNil(sut.retrieveLocallyStoredStateName(of: address))

diff --git a/...elated/Dashboard/Settings/In-Person Payments/TapToPayAwarenessMomentDeterminerTests.swift b/...elated/Dashboard/Settings/In-Person Payments/TapToPayAwarenessMomentDeterminerTests.swift
@@ -165,7 +165,7 @@ struct TapToPayAwarenessMomentDeterminerTests {
         userDefaults.hasFirstAttempt = false
 
         // When shouldPresent called
-        let shouldPresent = await sut.shouldPresent()
+        _ = await sut.shouldPresent()
 
         // Then
         #expect(userDefaults.hasFirstAttempt)

diff --git a/WooCommerce/WooCommerceTests/ViewRelated/Products/ProductListViewModelTests.swift b/WooCommerce/WooCommerceTests/ViewRelated/Products/ProductListViewModelTests.swift
@@ -346,9 +346,9 @@ final class ProductListViewModelTests: XCTestCase {
     func test_it_loads_favorite_products_on_init() {
         // Given
         let favoriteProductsUseCase = MockFavoriteProductsUseCase()
-        let viewModel = ProductListViewModel(siteID: sampleSiteID,
-                                             stores: storesManager,
-                                             favoriteProductsUseCase: favoriteProductsUseCase)
+        _ = ProductListViewModel(siteID: sampleSiteID,
+                                 stores: storesManager,
+                                 favoriteProductsUseCase: favoriteProductsUseCase)
 
         // Then
         waitUntil {

diff --git a/Yosemite/Yosemite/Model/Mocks/ActionHandlers/MockPaymentActionHandler.swift b/Yosemite/Yosemite/Model/Mocks/ActionHandlers/MockPaymentActionHandler.swift
@@ -16,7 +16,7 @@ struct MockPaymentActionHandler: MockActionHandler {
 
     func handle(action: PaymentAction) {
         switch action {
-        case .loadSiteCurrentPlan(siteID: let siteID, completion: let completion):
+        case .loadSiteCurrentPlan(siteID: _, completion: let completion):
             let mockPlan = WPComSitePlan(
                 id: "mock_plan_id",
                 hasDomainCredit: true,

diff --git a/Yosemite/YosemiteTests/Stores/SystemStatusStoreTests.swift b/Yosemite/YosemiteTests/Stores/SystemStatusStoreTests.swift
@@ -61,7 +61,7 @@ final class SystemStatusStoreTests: XCTestCase {
         let store = SystemStatusStore(dispatcher: dispatcher, storageManager: storageManager, network: network)
 
         // When
-        let result = waitFor { promise in
+        _ = waitFor { promise in
             store.onAction(SystemStatusAction.synchronizeSystemInformation(siteID: self.sampleSiteID) { result in
                 promise(result)
             })