Apply suggestions from code review

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
withastro · lilnasy · Feb 21, 2024 · Feb 16, 2024 · Feb 16, 2024 · Feb 16, 2024
commit 9b54fb747408e2afc5ec42703b878e4bd5c62bdc
diff --git a/internal/transform/transform.go b/internal/transform/transform.go
@@ -412,31 +412,31 @@
 		}
 		h.AppendHint(&loc.ErrorWithRange{
 			Code:  loc.HINT,
-			Text:  "Astro processes your script tags to allow using TypeScript and npm packages, and to optimize browser performance.\n\nAttributes cannot be used on Astro-processed script tags. Therefore, this script tag will be treated as if it has the `is:inline` directive, opting it out of the processing steps and its features.\n\nFor clarity, you might want to add the `is:inline` directive explicitly.\n\nSee docs for more details: https://docs.astro.build/en/guides/client-side-scripts/#script-processing.",
+			Text: "This script contains an attribute (ex: `type="module"`, `type="text/partytown"`, `async`) or a directive (`define:vars`) and will not be processed and bundled for optimized browser performance.\n\nThis script will be treated as if it has the `is:inline` directive and therefore features that require processing (e.g. using TypeScript or npm packages in the script) are unavailable.\n\nSee docs for more details: https://docs.astro.build/en/guides/client-side-scripts/#script-processing.",
 			Range: loc.Range{Loc: n.Attr[0].KeyLoc, Len: len(n.Attr[0].Key)},
 		})
 	}
 }

 func AddComponentProps(doc *astro.Node, n *astro.Node, opts *TransformOptions) {
 	if n.Type == astro.ElementNode && (n.Component || n.CustomElement) {
 		for _, attr := range n.Attr {
 			if strings.HasPrefix(attr.Key, "client:") {
 				parts := strings.Split(attr.Key, ":")
 				directive := parts[1]

 				// Add the hydration directive so it can be extracted statically.
 				doc.HydrationDirectives[directive] = true

 				hydrationAttr := astro.Attribute{
 					Key: "client:component-hydration",
 					Val: directive,
 				}
 				n.Attr = append(n.Attr, hydrationAttr)

 				if attr.Key == "client:only" {
 					doc.ClientOnlyComponentNodes = append([]*astro.Node{n}, doc.ClientOnlyComponentNodes...)

 					match := matchNodeToImportStatement(doc, n)
 					if match != nil {
 						doc.ClientOnlyComponents = append(doc.ClientOnlyComponents, &astro.HydratedComponentMetadata{