Only fire is dirty event for custom editor when the editor model is a…

…ctually dirty Fixes #86551 Firing isDirty causes the editor to become pinned. We don't want this to happen by if no edits have happened
winzig · Dec 18, 2019 · 906b111 · 906b111
1 parent 5d9bcb2
commit 906b111
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/vs/workbench/contrib/customEditor/browser/customEditorInput.ts b/src/vs/workbench/contrib/customEditor/browser/customEditorInput.ts
@@ -143,7 +143,9 @@ export class CustomFileEditorInput extends LazilyResolvedWebviewEditorInput {
 	public async resolve(): Promise<IEditorModel> {
 		this._model = await this.customEditorService.models.loadOrCreate(this.getResource(), this.viewType);
 		this._register(this._model.onDidChangeDirty(() => this._onDidChangeDirty.fire()));
-		this._onDidChangeDirty.fire();
+		if (this.isDirty()) {
+			this._onDidChangeDirty.fire();
+		}
 		return await super.resolve();
 	}