Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for user-assigned managed identities #2678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fardarter
Copy link

@fardarter fardarter commented Oct 14, 2024

This will allow for using user-assigned managed identities when both the bool UseMsi and the ClientId are specified.

Note, this matches the pattern for the az cli login: az login --identity --username <client_id|object_id|resource_id> (https://learn.microsoft.com/en-us/cli/azure/authenticate-azure-cli-managed-identity)

I'd also be happy to update the docs. I'm not sure what your testing regime is like?

@WouterTinus
Copy link
Member

Hi @fardarter! Thanks for this contribution, it looks like it will be nice to have. But I won't be merging any more PRs in this repo, because I'm working on a new cross-platform version of the program called simple-acme instead. Would you please consider contributing to https://github.com/simple-acme/simple-acme/?

@fardarter
Copy link
Author

Hi @fardarter! Thanks for this contribution, it looks like it will be nice to have. But I won't be merging any more PRs in this repo, because I'm working on a new cross-platform version of the program called simple-acme instead. Would you please consider contributing to https://github.com/simple-acme/simple-acme/?

Hi @WouterTinus. If you have feature parity on simple-acme, perhaps it would be good to add a big banner on the win-acme docs to direct people to simple-acme. I hadn't realised that development on win-acme would be ending, which would have led to me choosing the other option (if it's in a viable state).

I'm happy to make the contribution to simple-acme but what are the plans for work on win-acme? I posed the question re the .NET8 runtime upgrade earlier this month and you said there would be a new version, so I'm assuming work isn't coming to a complete halt?

@WouterTinus
Copy link
Member

Hi @fardarter, thanks for your feedback. The simple-acme fork has been a bit of stealth effort so far, but I'll soon start making some more noise about it and communicate much more clearly to all users that it's the future of the client as far as I'm concerned.

I'm still mulling the details of the transition a bit, so for now I'm slowly recruiting contributors and people waiting on specific bug fixes as early adopers 😉

@fardarter
Copy link
Author

@WouterTinus I actually did the swap yesterday and it was seamless. Only one thing is that I can't seem to get it working is the --test flag without it hanging (it's automated). Would be grateful for more advice there (I used the ‑‑closeonfinish flag but it didn't).

Also, in general, I can't find the docs repo. I'd like to update the docs to reflect the new capability when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants