perf: fix minification regression (QwikDev#1957)

fixes QwikDev#1906
willkuerlich · Nov 2, 2022 · 66ebede · 66ebede
1 parent cf626bf
commit 66ebede
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 11 deletions.
diff --git a/packages/qwik-city/package.json b/packages/qwik-city/package.json
@@ -3,7 +3,6 @@
   "version": "0.0.118",
   "description": "The meta-framework for Qwik.",
   "main": "./lib/index.qwik.mjs",
-  "module": "./lib/index.qwik.mjs",
   "qwik": "./lib/index.qwik.mjs",
   "types": "./lib/index.d.ts",
   "type": "module",

diff --git a/packages/qwik-react/package.json b/packages/qwik-react/package.json
@@ -58,7 +58,6 @@
   },
   "type": "module",
   "main": "./lib/index.qwik.mjs",
-  "module": "./lib/index.qwik.mjs",
   "qwik": "./lib/index.qwik.mjs",
   "types": "./lib/types/index.d.ts"
 }
diff --git a/packages/qwik/package.json b/packages/qwik/package.json
@@ -3,15 +3,17 @@
   "version": "0.12.1",
   "description": "An Open-Source sub-framework designed with a focus on server-side-rendering, lazy-loading, and styling/animation.",
   "main": "./dist/core.mjs",
-  "module": "./dist/core.mjs",
   "types": "./dist/core.d.ts",
   "bin": "./dist/qwik.cjs",
   "type": "module",
   "sideEffects": false,
   "exports": {
     ".": {
+      "browser": {
+        "production": "./dist/core.min.mjs",
+        "default": "./dist/core.mjs"
+      },
       "import": {
-        "min": "./dist/core.min.mjs",
         "production": "./dist/core.prod.mjs",
         "default": "./dist/core.mjs"
       },

diff --git a/packages/qwik/src/optimizer/src/plugins/vite.ts b/packages/qwik/src/optimizer/src/plugins/vite.ts
@@ -282,9 +282,6 @@ export function qwikVite(qwikViteOpts: QwikVitePluginOptions = {}): any {
           }
         }
       } else if (opts.target === 'client') {
-        if (buildMode === 'production') {
-          updatedViteConfig.resolve!.conditions = ['min'];
-        }
         // Client Build
         if (isClientDevOnly) {
           updatedViteConfig.build!.rollupOptions!.input = clientDevInput;

diff --git a/scripts/package-json.ts b/scripts/package-json.ts
@@ -16,7 +16,6 @@ export async function generatePackageJson(config: BuildConfig) {
     description: rootPkg.description,
     license: rootPkg.license,
     main: './core.mjs',
-    module: './core.mjs',
     types: './core.d.ts',
     bin: {
       qwik: './qwik.cjs',
@@ -25,8 +24,11 @@ export async function generatePackageJson(config: BuildConfig) {
     exports: {
       '.': {
         types: './core.d.ts',
+        browser: {
+          production: './core.min.mjs',
+          default: './core.mjs',
+        },
         import: {
-          min: './core.min.mjs',
           production: './core.prod.mjs',
           default: './core.mjs',
         },

diff --git a/scripts/qwik-city.ts b/scripts/qwik-city.ts
@@ -41,7 +41,6 @@ export async function buildQwikCity(config: BuildConfig) {
   const loaderPkg = {
     ...(await readPackageJson(inputDir)),
     main: './index.qwik.mjs',
-    module: './index.qwik.mjs',
     qwik: './index.qwik.mjs',
     types: './index.d.ts',
     type: 'module',

diff --git a/starters/apps/library/package.json b/starters/apps/library/package.json
@@ -5,7 +5,6 @@
   "private": false,
   "main": "./lib/index.qwik.mjs",
   "qwik": "./lib/index.qwik.mjs",
-  "module": "./lib/index.qwik.mjs",
   "types": "./lib-types/index.d.ts",
   "type": "module",
   "exports": {