Re-enable the DNS server (localstack#9)

* Bump version in the readme * Use DNS_ADDRESS=127.0.0.1 rather than 0
whummer · Nov 24, 2023 · 8754795 · 8754795
1 parent a5db30b
commit 8754795
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -15,7 +15,7 @@ To get started, you can use this minimal example:
 
 ```yml
 - name: Start LocalStack
-  uses: LocalStack/setup-localstack@v0.1.2
+  uses: LocalStack/setup-localstack@v0.1.3
   with:
     image-tag: 'latest'
     install-awslocal: 'true'
@@ -32,7 +32,7 @@ To get started, you can use this minimal example:
 | `configuration`    | Configuration variables to use while starting LocalStack container               | `None`   |
 | `use-pro`          | Whether to use the Pro version of LocalStack (requires API key to be configured) | `false`  |
 
-> **NOTE**: The `LOCALSTACK_API_KEY` environment variable is required to be set if `use-pro` is set to `true`. While starting the [localstack-pro](https://hub.docker.com/r/localstack/localstack-pro) image, the DNS startup is skipped with `DNS_ADDRESS=0` configuration variable. It is required to properly start LocalStack in GitHub Actions runner environment.
+> **NOTE**: The `LOCALSTACK_API_KEY` environment variable is required to be set if `use-pro` is set to `true`.
 
 ### Example workflow
 
@@ -48,7 +48,7 @@ jobs:
       - uses: actions/checkout@v3
 
       - name: Start LocalStack
-        uses: LocalStack/setup-localstack@v0.1.2
+        uses: LocalStack/setup-localstack@v0.1.3
         with:
           image-tag: 'latest'
           install-awslocal: 'true'

diff --git a/action.yml b/action.yml
@@ -53,7 +53,7 @@ runs:
 
         if [ "$USE_PRO" = true ]; then
           docker pull localstack/localstack-pro:"$IMAGE_TAG" &
-          CONFIGURATION="$CONFIGURATION DNS_ADDRESS=0"
+          CONFIGURATION="$CONFIGURATION DNS_ADDRESS=127.0.0.1"
         else
           docker pull localstack/localstack:"$IMAGE_TAG" &
         fi