Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter copr spec file for Fedora 41 and Rawhide #6200

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Alter copr spec file for Fedora 41 and Rawhide #6200

merged 1 commit into from
Oct 31, 2024

Conversation

loops
Copy link
Contributor

@loops loops commented Sep 27, 2024

SlouchyButton mentioned in #6015 that a Fedora Openssl packaging change was likely causing a problem for the copr build.

The deprecated engine header has been broken out into its own package. Add a dependency on it for Fedora 41 and Rawhide.

SlouchyButton mentioned in wez#6015 that a Fedora Openssl
packaging change was likely causing a problem for the
copr build.

The deprecated engine header has been broken out into
its own package.  Add a dependency on it for Fedora 41
and Rawhide.
@SlouchyButton
Copy link

Just a note here, this might stop working in future Fedora versions as the use is deprecated. Ideally, the OpenSSL engine should not be used, but since wezterm is not using it directly afaik, there is a chance that newer versions of the dependency that does use it will fix it before it becomes a problem.

Otherwise, this looks good, slight problem is that when I tried to mockbuild the new spec file it seems that time dependency fails to build, possibly due to newer rust.

error[E0282]: type annotations needed for `Box<_>`
  --> /builddir/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.31/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update`

This shouldn't really block this PR as it is unrelated, but will also need further investigation to fix.

@rphillips
Copy link

@wez This does fix the issue and build on Fedora 41 beta. The github CI run looks like a flake. Can we get this merged?

@inknos
Copy link

inknos commented Oct 24, 2024

I believe some fix will be needed for the file get-deps as well for local builds.

@@ -89,7 +89,7 @@ fedora_deps() {
     'gcc-c++' \
     'flatpak-builder' \
     'fontconfig-devel' \
-    'openssl-devel' \
+    'openssl-devel-engine' \
     'perl-interpreter' \
     'python3' \
     'python3-pip' \

(Or if it affects some fedora versions only, a condition is needed)

I think it is not bad to add it right away since openssl-devel is a dep of openssl-devel-engine in fedora >= 39

@SlouchyButton
Copy link

Or if it affects some fedora versions only, a condition is needed

F41+ - since F41, the OpenSSL engine use is deprecated.

@wez wez merged commit 6a0ed04 into wez:main Oct 31, 2024
3 of 13 checks passed
@wez
Copy link
Owner

wez commented Oct 31, 2024

Thanks!

@wez wez mentioned this pull request Oct 31, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants