Line wrapping #5096
Draft
Line wrapping #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feels more like a workaround.
I would expect, that when a program prints exactly
as many chars as there a columns, the cursor would wrap
into the next line. This would be possible by putting
another "if self.wrap_next {" block after the for loop
in the performer. But it seems like there are programs
that depend on it not doing that, e.g. fish shell.
It prints a full line of mostly spaces and then does \r,
expecting the cursor is still on the same line.
This way, the cursor overflows into an extra column,
but I'm sure this has its own disadvantages. Perhaps
this commit should not be used at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
clear && echo -n some really long long text1 && readclear && echo -n "test test test " && readclear && echo -en "abc\n\n\n\n" && readNot regressed:
clear && echo -en "aaa\nbbbbbbbbbb\ncc\033[2;11H" && readclear && echo -n some long long text && readNoteworthy:
https://github.com/faho/fish-shell/blob/8c620cb5ccbf5955d6271fd3460c1f799d91abd1/share/functions/__fish_config_interactive.fish#L244-L262
Since it doesn't do so for wezterm, line wrapping will have the usual issues just like with bash. But it's possible to test out what it would look like without their redrawing:
KONSOLE_VERSION=210400 ./target/debug/wezterm -e fishOpen questions:
set_editedfor Cell actually fine?I wouldn't be surprised if there are still changes needed for this PR to land. But right now, I don't feel like working on this PR anymore, and if there are still some things to do, anyone is free to take over this PR. Even if this PR doesn't land, it might serve as an inspiration for other line wrapping PRs.