-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve integrated titlebar buttons on macos #4727
Draft
yuraiz
wants to merge
7
commits into
wez:main
Choose a base branch
from
yuraiz:macos-titlebar-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuraiz
force-pushed
the
macos-titlebar-improvements
branch
2 times, most recently
from
December 29, 2023 12:46
540e442
to
95b7faa
Compare
its good! |
will it be merge? its looks cool |
It isn't finished yet and not even ready for review |
It doesn't accept null.
I didn't notice unhandled cases, but possibly some of the cases are handled in wrong methods.
yuraiz
force-pushed
the
macos-titlebar-improvements
branch
from
October 1, 2024 19:29
95b7faa
to
ba8aa32
Compare
yuraiz
force-pushed
the
macos-titlebar-improvements
branch
from
October 1, 2024 21:03
843e3f5
to
4ea0549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-12-29.at.15.47.24.mov
I found a way to move traffic lights, it seems to work as I want to, but needs some improvements
TODO: