feat: monomorphic ResolveRequest object #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 20 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- lib/ResolverFactory.js: Evaluated as low risk
- lib/ModulesInHierarchicalDirectoriesPlugin.js: Evaluated as low risk
- lib/SymlinkPlugin.js: Evaluated as low risk
- lib/ModulesInRootPlugin.js: Evaluated as low risk
- lib/AppendPlugin.js: Evaluated as low risk
- lib/DescriptionFilePlugin.js: Evaluated as low risk
- lib/JoinRequestPartPlugin.js: Evaluated as low risk
- lib/ExportsFieldPlugin.js: Evaluated as low risk
- lib/AliasFieldPlugin.js: Evaluated as low risk
- lib/ResultPlugin.js: Evaluated as low risk
- lib/AliasPlugin.js: Evaluated as low risk
- lib/RootsPlugin.js: Evaluated as low risk
- lib/ImportsFieldPlugin.js: Evaluated as low risk
- lib/CloneBasenamePlugin.js: Evaluated as low risk
- lib/JoinRequestPlugin.js: Evaluated as low risk
Comments suppressed due to low confidence (1)
lib/ParsePlugin.js:55
- The logic for setting the 'fragment' property might not correctly handle cases where both 'parsed.fragment' and 'request.fragment' are falsy. Consider using 'parsed.fragment ?? request.fragment' to handle these cases correctly.
fragment: parsed.fragment || request.fragment || parsed.fragment,
|
|
||
| request: parsed.request, | ||
| // If parsed.query and request.query are both falsy, prefer parsed.query | ||
| query: parsed.query || request.query || parsed.query, |
There was a problem hiding this comment.
The logic for setting the 'query' property might not correctly handle cases where both 'parsed.query' and 'request.query' are falsy. Consider using 'parsed.query ?? request.query' to handle these cases correctly.
Suggested change
| query: parsed.query || request.query || parsed.query, | |
| query: parsed.query ?? request.query, |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
This is expressly written the way it is written for the scenario where parsed.query and request.query are both falsy, such that it shall prefer the raw value of parsed.query in that scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance all-up (especially in
ParsePlugin,JoinRequestPlugin,JoinRequestPartPlugin) by ensuring that theResolveRequestobject always has a constant shape.Note that this is technically a breaking change to plugin authors, if they took a dependency on the ability to attach arbitrary properties to the
ResolveRequestobject to pass them between plugins and out of the resolver, instead of using thecontextproperty.Additionally, creating the object via a direct object literal is significantly faster than creating it via object spread.
Testing on NodeJS 18.19.1, this had the following impact for a local webpack build.
Before:
After:
