Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cicp-display-p3.png is an invalid PNG #48107

Closed
LucasChollet opened this issue Sep 11, 2024 · 3 comments · Fixed by #48108
Closed

cicp-display-p3.png is an invalid PNG #48107

LucasChollet opened this issue Sep 11, 2024 · 3 comments · Fixed by #48108

Comments

@LucasChollet
Copy link
Contributor

In png/support/cicp-display-p3.png the chunk order is the following:
-IHDR
-PLTE
-cICP
-IDAT
-IEND

However, according to this section of the spec, the ordering is incorrect.
To also quote 11.3.2.6 cICP Coding-independent code points for video signal type identification exactly:

The cICP chunk MUST come before the PLTE and IDAT chunks.

@ProgramMax you might be interested.
I'll open a PR to fix that.
@ProgramMax
Copy link
Contributor

Good catch. Thank you.
I've attached a corrected PNG. I simply swapped the locations of the PLTE and cICP chunks.

Feel free to create a PR using this and I'll approve it.
cicp-display-p3

@LucasChollet LucasChollet mentioned this issue Sep 11, 2024
Merged
@LucasChollet
Copy link
Contributor Author

You can thank jbowler, he's the one who caught that.

I did not use your image, but they are byte-identical.

@ProgramMax
Copy link
Contributor

Well then, thank you @jbowler

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make cicp-display-p3.png spec conformant LucasChollet/wpt
2 participants
@ProgramMax @LucasChollet