Tags: wearefrank/ladybug-frontend
Tags
Refactored table component directives to new conventions (#419) * chore: modernized table component directives condensed ts showCompareButton and ts showOpenInTabButton into ts getAmountOfReportsSelected and used a @switch to determine which button to show replaced ngIf, ngFor and [hidden] with the modern @if or @for directive * chore: added suggested changes for PR removed form for the input group for the uploadFile button, the type was removed and data-cy attribute was moved to the button element. e2e test was adjusted for this. changed to if's to an if-else. Moved method call from click in tableBody to the main tr element * chore: added suggested changes Replaced '> input' with .find('input') in fileupload test Changed class name for css to input-group-container to not interfere with bootstrap css Tracking row.storageId to follow conventions Added forgotten double quotes around index in table component html. * chore: extra find() call for less flackyness in debugtreeguardedcopy method
Added a new filter-side-drawer component for filtering reports (#390) * initial commit with first version of the side panel for filters. old filter has been commented out * added animation for the filter-side-drawer * made the first input fields for the metadatanames in the filter view. needs to be aligned correctly including other elements in the filter-side-drawer * made the filter side drawer look better with the input fields and made the basic method calls for updating the filter. it just needs to call the updatefilters method in table component now * put the filter fields next to each other for readability of code * added functionality to filter side drawer with the help of filter.service.ts table component functionality has barely been changed. only difference is that the api request now accepts string arrays so the parameters for the api call have also been changed. * Title change of filter side drawer * Update src/app/debug/filter-side-drawer/filter-side-drawer.component.html Co-authored-by: Sergi Philipsen <philipsen.sergi@gmail.com> * Update src/app/debug/filter-side-drawer/filter-side-drawer.component.ts Co-authored-by: Sergi Philipsen <philipsen.sergi@gmail.com> * Removed unnecessary line of code from filter-side-drawer.component.ts * changed name and order of observables and subjects of the filter.service.ts * refactor for code review. removed resetFilter from filter-side-drawer.component.ts as the trigger might as well call the resetFitler directly in the filterService. updateFilter parameter type added. Added autocomplete feature for filter options. Fixes a known ladybug-frontend issue Fixed filter side drawer size option. now possible to scroll if screen is too small * added unit tests for the mat autocomplete element * ngModelChange is now used to detect changes to user input. for filterContext a debounceTime was added to not overload the API. added cleardebugStorage() to afterEach() cypress e2e test for the filter table * filter is closed at the end of test * changed some api request issues. api was called multiple times when trying to refresh, filter reset has been removed from refresh method. moved creation of subscription in table component to ngInit to avoid multiple instances of a subscription being formed added refresh method to cypress tests * minor fixes to the structure of the code. subscriptions moved to dedicated subscribe and unsubscribe methods. Records have been changed to Maps for consistency. small css changes. Added a type to one of the subscribers where I forgot to add one. made filter-side-drawer.component.ts standalone Changed ngIf to an @if in filter-side-drawer.component.html Replaced the empty mat-option with a clear button that shows next to the metadata input element. updated the cypress e2e test accordingly with the new clear button * added word-break because correlationId would clip outside of container in firefox * added imports to spec file * FilterSideDrawerComponent removed from declaration and added to imports * Update src/app/debug/filter-side-drawer/filter-side-drawer.component.css Co-authored-by: Matthijs Smets <93487259+MatthijsSmets@users.noreply.github.com> * chore: change some styling in the filter side drawer * chore: added missing unsubscribe calls to table component * chore: removed console.logs and changed foreach loop to for loop in filter component * chore: removed unnecessary foreach and added more types to methods where it was missing. * chore: fixed some styling issues * chore: removed an unnecessary casting to string array * Update src/app/debug/filter-side-drawer/filter-side-drawer.component.html Co-authored-by: Matthijs Smets <93487259+MatthijsSmets@users.noreply.github.com> * Update src/app/debug/filter-side-drawer/filter-side-drawer.component.html Co-authored-by: Matthijs Smets <93487259+MatthijsSmets@users.noreply.github.com> --------- Co-authored-by: Sergi Philipsen <philipsen.sergi@gmail.com> Co-authored-by: Matthijs Smets <93487259+MatthijsSmets@users.noreply.github.com> Co-authored-by: MatthijsSmets <s1122126@student.hsleiden.nl>
Pretty print for json files (#372) * feat: pretty print is available for json files * chore: cleanup code * chore: fix test * chore: fix issues pointed out in pr comments * chore: fix error * chore: fix error * chore: clean up code --------- Co-authored-by: MatthijsSmets
Test/settings component (#331) * test: create test for spacing setting * test: create test for show multiple files in file tree * chore: fix new tests to run independently * chore: move test file to test root directory * chore: change test file extension to js * chore: fix tests
PreviousNext