Bump to latest firebase messaging

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
waqashaneef · Mar 23, 2020 · 271e163 · 271e163
1 parent ac6bcb1
commit 271e163
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 78 deletions.
diff --git a/gplay.gradle b/gplay.gradle
@@ -1,3 +1,3 @@
 dependencies {
-    implementation "com.google.firebase:firebase-messaging:17.3.0"
+    implementation "com.google.firebase:firebase-messaging:20.1.3"
 }
diff --git a/src/gplay/AndroidManifest.xml b/src/gplay/AndroidManifest.xml
@@ -66,13 +66,6 @@
             </intent-filter>
         </service>
 
-        <service
-            android:name=".services.firebase.NCFirebaseInstanceIDService">
-            <intent-filter>
-                <action android:name="com.google.firebase.INSTANCE_ID_EVENT"/>
-            </intent-filter>
-        </service>
-
         <service
             android:name="com.evernote.android.job.gcm.PlatformGcmService"
             android:enabled="true"

diff --git a/src/gplay/java/com/nextcloud/client/di/VariantComponentsModule.java b/src/gplay/java/com/nextcloud/client/di/VariantComponentsModule.java
@@ -20,14 +20,15 @@
 package com.nextcloud.client.di;
 
 import com.owncloud.android.authentication.ModifiedAuthenticatorActivity;
-import com.owncloud.android.services.firebase.NCFirebaseInstanceIDService;
+import com.owncloud.android.services.firebase.NCFirebaseMessagingService;
 
 import dagger.Module;
 import dagger.android.ContributesAndroidInjector;
 
 @Module
 abstract class VariantComponentsModule {
-    @ContributesAndroidInjector abstract NCFirebaseInstanceIDService ncFirebaseInstanceIDService();
+    @ContributesAndroidInjector
+    abstract NCFirebaseMessagingService nCFirebaseMessagingService();
 
     @ContributesAndroidInjector
     abstract ModifiedAuthenticatorActivity modifiedAuthenticatorActivity();

diff --git a/src/gplay/java/com/owncloud/android/services/firebase/NCFirebaseInstanceIDService.java b/src/gplay/java/com/owncloud/android/services/firebase/NCFirebaseInstanceIDService.java
diff --git a/src/gplay/java/com/owncloud/android/services/firebase/NCFirebaseMessagingService.java b/src/gplay/java/com/owncloud/android/services/firebase/NCFirebaseMessagingService.java
@@ -19,28 +19,56 @@
  */
 package com.owncloud.android.services.firebase;
 
+import android.text.TextUtils;
+
 import com.evernote.android.job.JobRequest;
 import com.evernote.android.job.util.support.PersistableBundleCompat;
 import com.google.firebase.messaging.FirebaseMessagingService;
 import com.google.firebase.messaging.RemoteMessage;
+import com.nextcloud.client.account.UserAccountManager;
+import com.nextcloud.client.preferences.AppPreferences;
+import com.owncloud.android.R;
 import com.owncloud.android.jobs.NotificationJob;
+import com.owncloud.android.utils.PushUtils;
+
+import javax.inject.Inject;
+
+import androidx.annotation.NonNull;
+import dagger.android.AndroidInjection;
 
 public class NCFirebaseMessagingService extends FirebaseMessagingService {
+    @Inject AppPreferences preferences;
+    @Inject UserAccountManager accountManager;
+
+    @Override
+    public void onCreate() {
+        super.onCreate();
+        AndroidInjection.inject(this);
+    }
 
     @Override
-    public void onMessageReceived(RemoteMessage remoteMessage) {
-        if (remoteMessage != null && remoteMessage.getData() != null) {
-            PersistableBundleCompat persistableBundleCompat = new PersistableBundleCompat();
-            persistableBundleCompat.putString(NotificationJob.KEY_NOTIFICATION_SUBJECT, remoteMessage.getData().get
-                    (NotificationJob.KEY_NOTIFICATION_SUBJECT));
-            persistableBundleCompat.putString(NotificationJob.KEY_NOTIFICATION_SIGNATURE, remoteMessage.getData().get
-                    (NotificationJob.KEY_NOTIFICATION_SIGNATURE));
-            new JobRequest.Builder(NotificationJob.TAG)
-                    .addExtras(persistableBundleCompat)
-                    .setUpdateCurrent(false)
-                    .startNow()
-                    .build()
-                    .schedule();
+    public void onMessageReceived(@NonNull RemoteMessage remoteMessage) {
+        remoteMessage.getData();
+        PersistableBundleCompat persistableBundleCompat = new PersistableBundleCompat();
+        persistableBundleCompat.putString(NotificationJob.KEY_NOTIFICATION_SUBJECT, remoteMessage.getData().get
+            (NotificationJob.KEY_NOTIFICATION_SUBJECT));
+        persistableBundleCompat.putString(NotificationJob.KEY_NOTIFICATION_SIGNATURE, remoteMessage.getData().get
+            (NotificationJob.KEY_NOTIFICATION_SIGNATURE));
+        new JobRequest.Builder(NotificationJob.TAG)
+            .addExtras(persistableBundleCompat)
+            .setUpdateCurrent(false)
+            .startNow()
+            .build()
+            .schedule();
+    }
+
+    @Override
+    public void onNewToken(@NonNull String newToken) {
+        super.onNewToken(newToken);
+
+        if (!TextUtils.isEmpty(getResources().getString(R.string.push_server_url))) {
+            preferences.setPushToken(newToken);
+            PushUtils.pushRegistrationToServer(accountManager, preferences.getPushToken());
         }
     }
 }