Merge pull request #8 from timp21337/master

Avoid logging db connection details
wakaleo · May 20, 2012 · a5a5d52 · a5a5d52
2 parents 2d688cb + 507cdce
commit a5a5d52
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/main/java/com/wakaleo/schemaspy/SchemaSpyReport.java b/src/main/java/com/wakaleo/schemaspy/SchemaSpyReport.java
@@ -304,6 +304,9 @@ public class SchemaSpyReport extends AbstractMavenReport {
 	 * Specifies additional properties to be used when connecting to the database.
 	 * Specify the entries directly, escaping the ='s with \= and separating each key\=value
 	 * pair with a ;.
+	 * 
+	 * May also be a file name, useful for hiding connection properties from public logs. 
+	 * 
 	 * @parameter connprops
 	 */
 	private String connprops;
@@ -460,7 +463,7 @@ protected void executeReport(Locale locale) throws MavenReportException {
 		addFlagToArguments(argList, "-sso", singleSignOn);
 		addFlagToArguments(argList, "-lq", lowQuality);
 		addFlagToArguments(argList, "-hq", highQuality);
-		addToArguments(argList, "connprops", connprops);
+		addToArguments(argList, "-connprops", connprops);
 		addFlagToArguments(argList, "-cid", commentsInitiallyDisplayed);
 		addFlagToArguments(argList, "-noads", noAds);
 		addFlagToArguments(argList, "-nologo", noLogo);

diff --git a/src/site/apt/faq.apt b/src/site/apt/faq.apt
@@ -99,4 +99,11 @@ but it keeps crashing on me.
 
  Sure. Just use the  <<<\<cssStylesheet\>>>> configuration option. The default one 
  is called schemaSpy.css, and can be found bundled in the plugin JAR (in the resources 
- directory). You can also check it out online in the Subversion repository.
+ directory). You can also check it out online in the Subversion repository.
+
+ * The SchemaSpy plugin is logging my database password, so exposing it in Jenkins logs. Can I hide it?
+
+ The way to do this is to put the database connection details in a separate file 
+ of key=value pairs containing a <<<password=mypassword>>> entry.
+ Point to that file with the <<<\<connprops\>>>> option.
+