Fixing issue #1570 #1572
Closed
Fixing issue #1570 #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardoAlbertoni
requested review from
pchampin,
dr-shorthair,
pwin,
agbeltran,
cburle,
andrea-perego and
davebrowning
davebrowning
previously approved these changes
Jun 20, 2023
There was a problem hiding this comment.
The file changes seem (to me) to address the specifics of the issue #1570 . There does seem to be some concerns that need to be discussed a little before moving ahead with this at this point, so I've revoked my approval pending that discussion happening in the issue.
andrea-perego
requested changes
Jul 29, 2023
There was a problem hiding this comment.
@riccardoAlbertoni , I'm not in favour of these revisions, for the reasons explained in #1570 (comment)
I think we should keep the current references, pointing to the ADMS version in W3C space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to refer to the ADMS document URL instead of Term URI.
With these changes we refer to w3c URI which turn into non W3C - ADMS latest documentation, https://semiceu.github.io/ADMS/releases/2.00/.
Closed #1570